New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Change, Travis Change, Doc Change #2338

Merged
merged 15 commits into from Nov 9, 2017

Conversation

Projects
None yet
4 participants
@nabobalis
Copy link
Contributor

nabobalis commented Nov 9, 2017

I have no idea how to label this without adding everything.

@nabobalis

This comment has been minimized.

Copy link
Contributor

nabobalis commented Nov 9, 2017

The example now plays out like this:

Figure 1:
figure_1

Figure 2:
figure_1-1

@nabobalis

This comment has been minimized.

Copy link
Contributor

nabobalis commented Nov 9, 2017

Travis looks like:

screenshot from 2017-11-09 15-36-42

Cron jobs are:
screenshot from 2017-11-09 15-40-34

@prateekiiest

This comment has been minimized.

Copy link
Contributor

prateekiiest commented Nov 9, 2017

Which example @nabobalis ?

@nabobalis

This comment has been minimized.

Copy link
Contributor

nabobalis commented Nov 9, 2017

@prateekiiest I merged the masking hot pixels and finding bright pixel into one

@prateekiiest

This comment has been minimized.

Copy link
Contributor

prateekiiest commented Nov 9, 2017

Figure 1 was the previous case before merged?

@nabobalis

This comment has been minimized.

Copy link
Contributor

nabobalis commented Nov 9, 2017

Pretty much. The masking example did not actually mask anything. I forgot to fix it a while back. Now it masks but its not pretty code.

@prateekiiest

This comment has been minimized.

Copy link
Contributor

prateekiiest commented Nov 9, 2017

ok, but its working

@nabobalis

This comment has been minimized.

Copy link
Contributor

nabobalis commented Nov 9, 2017

It is now. I have the output above.

x, y = np.meshgrid(*[np.arange(v.value) for v in aia.dimensions]) * u.pixel

###############################################################################
# Now we can convert this to helioprojective coordinates and create a new

This comment has been minimized.

@Cadair

Cadair Nov 9, 2017

Member

this text now seems out of sync with the rest of the example.

This comment has been minimized.

@nabobalis

nabobalis Nov 9, 2017

Contributor

I thought i changed that. Seems not!

This comment has been minimized.

@nabobalis

nabobalis Nov 9, 2017

Contributor

well thats still correct to what i do in the code no?

@Cadair

This comment has been minimized.

Copy link
Member

Cadair commented Nov 9, 2017

@nabobalis what's the motivation for merging those two examples?

@nabobalis

This comment has been minimized.

Copy link
Contributor

nabobalis commented Nov 9, 2017

@Cadair One example was a subset of the other, so I thought might as well get rid of the subset example.

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Nov 9, 2017

Hello @nabobalis! Thanks for updating the PR.

Line 53:101: E501 line too long (115 > 100 characters)
Line 58:101: E501 line too long (118 > 100 characters)
Line 64:101: E501 line too long (115 > 100 characters)
Line 69:101: E501 line too long (118 > 100 characters)
Line 76:11: E111 indentation is not a multiple of four
Line 80:101: E501 line too long (118 > 100 characters)
Line 83:1: E265 block comment should start with '# '
Line 85:1: E265 block comment should start with '# '
Line 106:1: W293 blank line contains whitespace
Line 117:1: E265 block comment should start with '# '
Line 119:1: E265 block comment should start with '# '
Line 122:9: E265 block comment should start with '# '
Line 127:9: E265 block comment should start with '# '
Line 132:9: E265 block comment should start with '# '
Line 137:9: E265 block comment should start with '# '
Line 142:9: E265 block comment should start with '# '
Line 145:1: W293 blank line contains whitespace
Line 147:9: E265 block comment should start with '# '
Line 152:9: E265 block comment should start with '# '
Line 157:9: E265 block comment should start with '# '
Line 162:9: E265 block comment should start with '# '
Line 166:1: E265 block comment should start with '# '
Line 168:1: E265 block comment should start with '# '
Line 203:31: E231 missing whitespace after ':'
Line 218:5: E303 too many blank lines (2)
Line 227:31: E231 missing whitespace after ':'
Line 251:34: E231 missing whitespace after ':'
Line 252:25: E231 missing whitespace after ':'
Line 253:37: E231 missing whitespace after ':'
Line 263:5: E303 too many blank lines (2)
Line 275:31: E231 missing whitespace after ':'
Line 276:33: E231 missing whitespace after ':'
Line 290:68: E231 missing whitespace after ','
Line 305:31: E231 missing whitespace after ':'
Line 306:33: E231 missing whitespace after ':'
Line 314:101: E501 line too long (108 > 100 characters)
Line 318:71: E231 missing whitespace after ','
Line 318:101: E501 line too long (113 > 100 characters)
Line 326:101: E501 line too long (102 > 100 characters)
Line 330:31: E231 missing whitespace after ':'
Line 331:37: E231 missing whitespace after ':'
Line 353:1: E265 block comment should start with '# '
Line 355:1: E265 block comment should start with '# '
Line 364:1: E265 block comment should start with '# '
Line 366:1: E265 block comment should start with '# '
Line 369:31: E231 missing whitespace after ':'
Line 391:101: E501 line too long (112 > 100 characters)
Line 394:101: E501 line too long (108 > 100 characters)
Line 397:101: E501 line too long (126 > 100 characters)
Line 401:39: E231 missing whitespace after ':'
Line 403:42: E231 missing whitespace after ':'
Line 418:1: W391 blank line at end of file

Comment last updated on November 09, 2017 at 22:16 Hours UTC
@nabobalis

This comment has been minimized.

Copy link
Contributor

nabobalis commented Nov 9, 2017

Since we have an issue with upstream astropy and changing GZIP data values, I added them as tests for GOES.

@nabobalis nabobalis force-pushed the nabobalis:master branch from f35c9b1 to 7349104 Nov 9, 2017

@nabobalis nabobalis force-pushed the nabobalis:master branch from 7349104 to 181d970 Nov 9, 2017

@@ -9,6 +9,13 @@ Bug Fixes
- Fix docstring formatting for net.vso.attrs [#2309]]
- Fix coloring of ticks under matplotlib 2.0 default style [#2320]
- Always index arrays with tuples in `ImageAnimator` [#2320]
- Misc Doc fixes [#2317] [#2289]
- Misc Readme Changes [#2281] [#2283]

This comment has been minimized.

@Cadair

Cadair Nov 9, 2017

Member

This is not a useful changelog entry!

This comment has been minimized.

@nabobalis

nabobalis Nov 9, 2017

Contributor

YES THEY ARE

@@ -1,32 +0,0 @@
"""
============================

This comment has been minimized.

@Cadair

Cadair Nov 9, 2017

Member

I think I am 👎 on removing this example. I know that it's basically the same as the other one, but it's a super simple reference example on over plotting coordinates.

This comment has been minimized.

@nabobalis

nabobalis Nov 9, 2017

Contributor

FINE

aia = sunpy.map.Map(AIA_171_IMAGE)

pixel_pos = np.argwhere(aia.data == aia.data.max())*u.pixel
hpc_max = aia.pixel_to_data(pixel_pos[:, 1], pixel_pos[:, 0])

This comment has been minimized.

@Cadair

Cadair Nov 9, 2017

Member

pixel_to_world

This comment has been minimized.

@nabobalis

nabobalis Nov 9, 2017

Contributor

FINE

nabobalis added some commits Nov 9, 2017

@Cadair

Cadair approved these changes Nov 9, 2017

@nabobalis nabobalis merged commit c404afb into sunpy:master Nov 9, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@nabobalis nabobalis referenced this pull request Nov 9, 2017

Merged

[0.8] Current Backports #2330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment