Example Change, Travis Change, Doc Change #2338

nabobalis · 2017-11-09T14:38:35Z

I have no idea how to label this without adding everything.

nabobalis · 2017-11-09T14:39:35Z

The example now plays out like this:

Figure 1:

Figure 2:

nabobalis · 2017-11-09T14:40:55Z

Travis looks like:

Cron jobs are:

prateekiiest · 2017-11-09T14:41:01Z

Which example @nabobalis ?

nabobalis · 2017-11-09T14:41:30Z

@prateekiiest I merged the masking hot pixels and finding bright pixel into one

prateekiiest · 2017-11-09T14:45:43Z

Figure 1 was the previous case before merged?

nabobalis · 2017-11-09T14:47:04Z

Pretty much. The masking example did not actually mask anything. I forgot to fix it a while back. Now it masks but its not pretty code.

prateekiiest · 2017-11-09T14:48:31Z

ok, but its working

nabobalis · 2017-11-09T14:48:49Z

It is now. I have the output above.

Cadair · 2017-11-09T15:02:56Z

examples/finding_masking_bright_pixels.py

+x, y = np.meshgrid(*[np.arange(v.value) for v in aia.dimensions]) * u.pixel
+
+###############################################################################
+# Now we can convert this to helioprojective coordinates and create a new


this text now seems out of sync with the rest of the example.

I thought i changed that. Seems not!

well thats still correct to what i do in the code no?

Cadair · 2017-11-09T15:03:46Z

@nabobalis what's the motivation for merging those two examples?

nabobalis · 2017-11-09T15:05:35Z

@Cadair One example was a subset of the other, so I thought might as well get rid of the subset example.

pep8speaks · 2017-11-09T16:18:22Z

Hello @nabobalis! Thanks for updating the PR.

In the file sunpy/timeseries/tests/test_timeseries_factory.py, following are the PEP8 issues :

Line 53:101: E501 line too long (115 > 100 characters)
Line 58:101: E501 line too long (118 > 100 characters)
Line 64:101: E501 line too long (115 > 100 characters)
Line 69:101: E501 line too long (118 > 100 characters)
Line 76:11: E111 indentation is not a multiple of four
Line 80:101: E501 line too long (118 > 100 characters)
Line 83:1: E265 block comment should start with '# '
Line 85:1: E265 block comment should start with '# '
Line 106:1: W293 blank line contains whitespace
Line 117:1: E265 block comment should start with '# '
Line 119:1: E265 block comment should start with '# '
Line 122:9: E265 block comment should start with '# '
Line 127:9: E265 block comment should start with '# '
Line 132:9: E265 block comment should start with '# '
Line 137:9: E265 block comment should start with '# '
Line 142:9: E265 block comment should start with '# '
Line 145:1: W293 blank line contains whitespace
Line 147:9: E265 block comment should start with '# '
Line 152:9: E265 block comment should start with '# '
Line 157:9: E265 block comment should start with '# '
Line 162:9: E265 block comment should start with '# '
Line 166:1: E265 block comment should start with '# '
Line 168:1: E265 block comment should start with '# '
Line 203:31: E231 missing whitespace after ':'
Line 218:5: E303 too many blank lines (2)
Line 227:31: E231 missing whitespace after ':'
Line 251:34: E231 missing whitespace after ':'
Line 252:25: E231 missing whitespace after ':'
Line 253:37: E231 missing whitespace after ':'
Line 263:5: E303 too many blank lines (2)
Line 275:31: E231 missing whitespace after ':'
Line 276:33: E231 missing whitespace after ':'
Line 290:68: E231 missing whitespace after ','
Line 305:31: E231 missing whitespace after ':'
Line 306:33: E231 missing whitespace after ':'
Line 314:101: E501 line too long (108 > 100 characters)
Line 318:71: E231 missing whitespace after ','
Line 318:101: E501 line too long (113 > 100 characters)
Line 326:101: E501 line too long (102 > 100 characters)
Line 330:31: E231 missing whitespace after ':'
Line 331:37: E231 missing whitespace after ':'
Line 353:1: E265 block comment should start with '# '
Line 355:1: E265 block comment should start with '# '
Line 364:1: E265 block comment should start with '# '
Line 366:1: E265 block comment should start with '# '
Line 369:31: E231 missing whitespace after ':'
Line 391:101: E501 line too long (112 > 100 characters)
Line 394:101: E501 line too long (108 > 100 characters)
Line 397:101: E501 line too long (126 > 100 characters)
Line 401:39: E231 missing whitespace after ':'
Line 403:42: E231 missing whitespace after ':'
Line 418:1: W391 blank line at end of file

Comment last updated on November 09, 2017 at 22:16 Hours UTC

nabobalis · 2017-11-09T16:19:07Z

Since we have an issue with upstream astropy and changing GZIP data values, I added them as tests for GOES.

Cadair · 2017-11-09T21:39:54Z

CHANGELOG.rst

@@ -9,6 +9,13 @@ Bug Fixes
 - Fix docstring formatting for net.vso.attrs [#2309]]
 - Fix coloring of ticks under matplotlib 2.0 default style [#2320]
 - Always index arrays with tuples in `ImageAnimator` [#2320]
+- Misc Doc fixes [#2317] [#2289]
+- Misc Readme Changes [#2281] [#2283]


This is not a useful changelog entry!

YES THEY ARE

Cadair · 2017-11-09T21:42:03Z

examples/brightness_pixel_location.py

@@ -1,32 +0,0 @@
-"""
-============================


I think I am 👎 on removing this example. I know that it's basically the same as the other one, but it's a super simple reference example on over plotting coordinates.

Cadair · 2017-11-09T21:42:23Z

examples/brightness_pixel_location.py

-aia = sunpy.map.Map(AIA_171_IMAGE)
-
-pixel_pos = np.argwhere(aia.data == aia.data.max())*u.pixel
-hpc_max = aia.pixel_to_data(pixel_pos[:, 1], pixel_pos[:, 0])


pixel_to_world

nabobalis added 7 commits November 9, 2017 14:48

Updated bright_pixel example

4c855e2

Changelog update

7677f0e

Travis test

82e9123

Doc change for atts

ab56427

Travis change 2

e9a8336

Travis stages part origins

9946ad8

Travis stages part origins v2

e27bf6e

Cadair reviewed Nov 9, 2017

View reviewed changes

New pip package due to upstream astropy changes

96a6536

nabobalis and others added 2 commits November 9, 2017 17:24

changed goes tests a bit

181d970

Merge branch 'master' into master

c4709ce

Cadair reviewed Nov 9, 2017

View reviewed changes

nabobalis added 4 commits November 9, 2017 23:08

Added back example

d7cdef0

CHange for example

203becd

CHangelog update

e2e6444

change log update

60a778c

woops for log

d1f5f2c

Cadair approved these changes Nov 9, 2017

View reviewed changes

nabobalis merged commit c404afb into sunpy:master Nov 9, 2017

nabobalis mentioned this pull request Nov 9, 2017

[0.8] Current Backports #2330

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Example Change, Travis Change, Doc Change #2338

Example Change, Travis Change, Doc Change #2338

nabobalis commented Nov 9, 2017

nabobalis commented Nov 9, 2017

nabobalis commented Nov 9, 2017

prateekiiest commented Nov 9, 2017

nabobalis commented Nov 9, 2017

prateekiiest commented Nov 9, 2017

nabobalis commented Nov 9, 2017

prateekiiest commented Nov 9, 2017

nabobalis commented Nov 9, 2017 •

edited

Cadair Nov 9, 2017

nabobalis Nov 9, 2017

nabobalis Nov 9, 2017

Cadair commented Nov 9, 2017 •

edited by nabobalis

nabobalis commented Nov 9, 2017

pep8speaks commented Nov 9, 2017 •

edited

nabobalis commented Nov 9, 2017 •

edited

Cadair Nov 9, 2017

nabobalis Nov 9, 2017

Cadair Nov 9, 2017

nabobalis Nov 9, 2017

Cadair Nov 9, 2017

nabobalis Nov 9, 2017

		@@ -1,32 +0,0 @@
		"""
		============================

Example Change, Travis Change, Doc Change #2338

Example Change, Travis Change, Doc Change #2338

Conversation

nabobalis commented Nov 9, 2017

nabobalis commented Nov 9, 2017

nabobalis commented Nov 9, 2017

prateekiiest commented Nov 9, 2017

nabobalis commented Nov 9, 2017

prateekiiest commented Nov 9, 2017

nabobalis commented Nov 9, 2017

prateekiiest commented Nov 9, 2017

nabobalis commented Nov 9, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cadair commented Nov 9, 2017 • edited by nabobalis

nabobalis commented Nov 9, 2017

pep8speaks commented Nov 9, 2017 • edited

Comment last updated on November 09, 2017 at 22:16 Hours UTC

nabobalis commented Nov 9, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nabobalis commented Nov 9, 2017 •

edited

Cadair commented Nov 9, 2017 •

edited by nabobalis

pep8speaks commented Nov 9, 2017 •

edited

nabobalis commented Nov 9, 2017 •

edited