added test for map save #2365
Merged
added test for map save #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @himanshukgp! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on December 13, 2017 at 13:39 Hours UTC |
Cadair
reviewed
Dec 13, 2017
sunpy/map/tests/test_mapbase.py
Outdated
| afilename = tempfile.NamedTemporaryFile(suffix='fits').name | ||
| eitmap.save(afilename, filetype='fits', clobber=True) | ||
| backin = sunpy.map.Map(afilename) | ||
| assert isinstance(backin, sunpy.map.sources.EITMap) |
There was a problem hiding this comment.
adding some test to make sure the data and meta attributes survied the trip would be very valuable.
|
Thanks @himanshukgp |
nabobalis
added
map
|
I just added two extra asserts for the data and header. |
|
@himanshukgp Thanks for this! Sorry for getting a bits handsy on it, I was just thinking of adding this for our next release (0.8.3)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2303