-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds filters for AstropyDeprecationWarning for 0.8 #2476
Conversation
Hello @yashkgp! Thanks for updating the PR.
Comment last updated on February 22, 2018 at 17:02 Hours UTC |
I just merged this locally and the warning still happens.
|
sunpy/coordinates/representation.py
Outdated
|
||
with warnings.catch_warnings(): | ||
warnings.simplefilter('ignore', AstropyDeprecationWarning) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that this is the correct way. But it isn't the right place in the script for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nabobalis , Mistakenly I was testing on older version of Astropy, that why I was not getting a warning on testing , hopefully issue is fixed now .
This seems to work now. We have some test issues but I think they are unrelated to the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it works...
Added a warning filter to tackle
AstropyDeprecationWarning
insunpy.coordinates.representation
in Sunpy 0.8 .