Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds filters for AstropyDeprecationWarning for 0.8 #2476

Merged
merged 3 commits into from
Feb 28, 2018

Conversation

yashkgp
Copy link
Contributor

@yashkgp yashkgp commented Feb 20, 2018

Added a warning filter to tackle AstropyDeprecationWarning in sunpy.coordinates.representation in Sunpy 0.8 .

@pep8speaks
Copy link

pep8speaks commented Feb 20, 2018

Hello @yashkgp! Thanks for updating the PR.

Line 11:1: E303 too many blank lines (3)
Line 20:47: E128 continuation line under-indented for visual indent
Line 21:47: E128 continuation line under-indented for visual indent
Line 26:1: E303 too many blank lines (3)
Line 27:10: E128 continuation line under-indented for visual indent
Line 70:3: E111 indentation is not a multiple of four
Line 73:3: E111 indentation is not a multiple of four
Line 73:3: E303 too many blank lines (2)
Line 74:7: E111 indentation is not a multiple of four
Line 97:7: E111 indentation is not a multiple of four
Line 98:7: E111 indentation is not a multiple of four
Line 101:3: E111 indentation is not a multiple of four
Line 101:3: E303 too many blank lines (2)
Line 102:7: E111 indentation is not a multiple of four
Line 125:7: E111 indentation is not a multiple of four
Line 127:7: E111 indentation is not a multiple of four
Line 129:7: E111 indentation is not a multiple of four
Line 132:1: W391 blank line at end of file

Comment last updated on February 22, 2018 at 17:02 Hours UTC

@yashkgp yashkgp changed the title Fixes Issue #2473 Added filters for AstropyDeprecationWarning for 0.8 Feb 20, 2018
@yashkgp yashkgp changed the title Added filters for AstropyDeprecationWarning for 0.8 Adds filters for AstropyDeprecationWarning for 0.8 Feb 20, 2018
@nabobalis
Copy link
Contributor

I just merged this locally and the warning still happens.

>>> from sunpy import coordinates
WARNING: AstropyDeprecationWarning: 
The 'recommended_units' attribute is deprecated since 3.0 and may be removed
in a future version. Its main use, of representing angles in degrees in frames,
is now done automatically in frames. Further overrides are discouraged but can
be done using a frame's ``frame_specific_representation_info``.
 [astropy.coordinates.representation]

@nabobalis nabobalis added this to the 0.8.5 milestone Feb 21, 2018

with warnings.catch_warnings():
warnings.simplefilter('ignore', AstropyDeprecationWarning)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that this is the correct way. But it isn't the right place in the script for this.

Copy link
Contributor Author

@yashkgp yashkgp Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nabobalis , Mistakenly I was testing on older version of Astropy, that why I was not getting a warning on testing , hopefully issue is fixed now .

@nabobalis
Copy link
Contributor

This seems to work now. We have some test issues but I think they are unrelated to the PR

Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants