Links on sub-package is working

[Naman9639]

Description

Fixes #2889

[ghost]

Thanks for the pull request @Naman9639! Everything looks great!

[nabobalis]

Doesn't seem to fix the issue if you try to access it: https://6077-2165383-gh.circle-artifacts.com/0/root/project/docs/_build/html/dev_guide/stability.html

I wonder why.

[Naman9639]

I will have a look at it again

[Naman9639]

I guess just removing the code_ref won't work

[nabobalis]

Yes it seems so.

[Naman9639]

Is there any way I can test this on my local machine? I mean any way so that I can have a look at the page after I make changes?

[nabobalis]

Yes you can build the documentation locally. python setup.py build_docs should work with all the doc dependencies installed.

[Naman9639]

Ahh ok. I will try that

[Naman9639]

`y: Traceback (most recent call last):
File "/home/naman/sunpy-git/examples/parse_time.py", line 23, in
t1 = parse_time('1995-12-31 23:59:60')
File "/home/naman/sunpy-git/build/lib.linux-x86_64-3.7/sunpy/time/time.py", line 310, in parse_time
rt = convert_time(time_string, format=format, **kwargs)
File "/home/naman/anaconda2/envs/sunpy-dev/lib/python3.7/functools.py", line 820, in wrapper
return dispatch(args[0].class)(*args, **kw)
File "/home/naman/sunpy-git/build/lib.linux-x86_64-3.7/sunpy/time/time.py", line 227, in convert_time_str
return Time.strptime(ts, time_format, **kwargs) + time_delta
AttributeError: type object 'Time' has no attribute 'strptime'

Exception occurred:
File "/home/naman/sunpy-git/build/lib.linux-x86_64-3.7/sunpy/time/time.py", line 227, in convert_time_str
return Time.strptime(ts, time_format, **kwargs) + time_delta
AttributeError: type object 'Time' has no attribute 'strptime'
The full traceback has been saved in /tmp/sphinx-err-5iin442b.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.`

This is the error. I guess there is something wrong with time.py

[nabobalis]

I think your version of astropy is out of date

[Naman9639]

Why is it that after running setup.py I am able to open every page in HTML format but only stability.html file does not opens on web browser as it should. It simply opens a webpage having the code written in stability,rst file

[nabobalis]

You mean the page has not rendered?

Did you install the dependency for that page? If not there should have been a warning in the build log.

[Naman9639]

Yes everything went well. There was no warning. I will try to run it again

[nabobalis]

Try to access that page using the index.html as well.

[Naman9639]

Ok I will try that

No. The page has not rendered

[Naman9639]

I build the docs again but the page won't render

[nabobalis]

Could try hard refreshing the page?

If it is not rendering, there must be a reason or a warning message. We know it renders online.

[nabobalis]

If it still doesn't work, we might need redo the page to follow how astropy do it.

[Naman9639]

UserWarning: Pandas doesn't allow columns to be created via a new attribute name - see https://pandas.pydata.org/pandas-docs/stable/indexing.html#attribute-access

That is the only warning I am getting

[nabobalis]

In that case, I am not sure I have a solution. You either have to try using the online builds or move onto another issue.

[Naman9639]

Oh ok I will try

[nabobalis]

can you try python setup.py build_docs -w

[Naman9639]

Sure I'll do it

[nabobalis]

Ah sorry, I meant python setup.py build_docs -w -l

[Naman9639]

That worked

[nabobalis]

it seemed to work for me locally if I do ./code_ref/{{ module }}.html

[Naman9639]

Oh, Ok. I will try that

[Naman9639]

This is not working because if we do ./code_ref/{{ module }}.html we get the following link
file:///home/naman/sunpy-git/docs/_build/html/dev_guide/code_ref/cm.html but we need to go to
file:///home/naman/sunpy-git/docs/_build/html/code_ref/cm.html

[nabobalis]

Ah i did not type it correctly. It was meant to be two dots.

../code_ref/{{ module }}.html

[Naman9639]

Yup I was about to say that because that worked for me

[nabobalis]

It works: https://6161-2165383-gh.circle-artifacts.com/0/root/project/docs/_build/html/dev_guide/stability.html

[nabobalis]

Thanks @Naman9639