Modified /sunpy/instr/goes.py so that 'hek' is imported only in the f…

[Akram9]

…unction that uses it.

Description

Solves the unexpected error as described in #2821 by moving import hek into get_goes_event_list.

Fixes #2821

[pep8speaks]

Hello @Akram9! Thanks for updating the PR.

• In the file sunpy/instr/goes.py, following are the PEP8 issues :

Line 44:101: E501 line too long (130 > 100 characters)
Line 821:101: E501 line too long (103 > 100 characters)
Line 822:101: E501 line too long (103 > 100 characters)
Line 823:101: E501 line too long (103 > 100 characters)
Line 824:101: E501 line too long (103 > 100 characters)
Line 825:101: E501 line too long (103 > 100 characters)
Line 826:101: E501 line too long (103 > 100 characters)
Line 976:5: E122 continuation line missing indentation or outdented

Comment last updated on February 23, 2019 at 17:57 Hours UTC

[ghost]

Thanks for the pull request @Akram9! Everything looks great!

[nabobalis]

You have also pulled in changes to astropy_helpers. You need to remove them.

Since you have committed the change, the best way would be to run:

git reset HEAD~
git submodule update --init
git add .
git commit

That should commit the change to the file only (in theory).

[Akram9]

I am having some problem with astropy_helpers. I had missed your earlier comment on reverting the changes and now I am not able to push. What should I do?
Will deleting this PR and doing it again help?

PS: I don't get how the astropy changes occured.

[nabobalis]

No, deleting it won't really help. How it happend, I am unsure since in theory it should have been checked out at the correct version. I wonder if this is the bug mentioned in #2932.

You won't be able to normally push if you change the history, you'd have to force push.
You can do the same commands as above but with:

git reset HEAD~2
git submodule update --init
git status (check here that astropy_helpers is unchanged. 
git add .
git commit -m <message>
git push --force

You want to check first command, I forget if it is ~1 oor ~2.

[Akram9]

I did as per your above code and it seems better now. Please check.

[nabobalis]

Yes that looks much beter now.

[Akram9]

So what do I do next?

[nabobalis]

Nothing, this will be merged once the checks clear.

[Akram9]

Thanks a lot!

[nabobalis]

Thank you @Akram9.

[Akram9]

Oh, thanks to you people. This was my first PR, and an enjoyable one at that.