Added mocking for test_eve.py

[yashrsharma44]

1. Used mocking to simulate online test
2. Online test function to cross-check the mocking function
3. Used parametrization wherever possible

Partial work for #2874

[pep8speaks]

Hello @yashrsharma44! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file sunpy/net/dataretriever/tests/test_eve.py:

Line 58:9: E128 continuation line under-indented for visual indent
Line 59:9: E128 continuation line under-indented for visual indent
Line 103:17: E128 continuation line under-indented for visual indent
Line 109:17: E128 continuation line under-indented for visual indent
Line 114:41: E231 missing whitespace after ','
Line 178:13: E128 continuation line under-indented for visual indent
Line 179:13: E128 continuation line under-indented for visual indent
Line 180:1: E124 closing bracket does not match visual indentation
Line 202:18: E127 continuation line over-indented for visual indent

Comment last updated at 2019-03-31 19:06:58 UTC

[ghost]

Thanks for the pull request @yashrsharma44! Everything looks great!

[vn-ki]

I'm so sorry for the style nits. 😅

[vn-ki]

IMO, you shouldn't use datetime in the codebase XD (Because we have switched to astropy.time for our time related stuff and it can do everything datetime can).

But maybe @Cadair and @nabobalis might have a different opinion.

[yashrsharma44]

I tried parsing the date in the %Y/%m/%d format in astropy.time if I remember it correctly. But it wasn't working in the way as expected. So I switched to datetime.

[nabobalis]

If it fails with astropy.time.Time it would be good to know, it might be a bug upstream. I would have thought that that would have worked with astropy.time.Time. But I have no real issue with using datetime in the tests.

[yashrsharma44]

Let me try that, I would update you with the working.

[yashrsharma44]

I got this error while parsing -

>>> from astropy import time
>>> a = time.Time('2012/10/4')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/yash/sunpydev/vnv37/lib/python3.7/site-packages/astropy/time/core.py", line 399, in __init__
    precision, in_subfmt, out_subfmt)
  File "/home/yash/sunpydev/vnv37/lib/python3.7/site-packages/astropy/time/core.py", line 454, in _init_from_vals
    precision, in_subfmt, out_subfmt)
  File "/home/yash/sunpydev/vnv37/lib/python3.7/site-packages/astropy/time/core.py", line 505, in _get_time_fmt
    raise ValueError('Input values did not match {0}'.format(err_msg))
ValueError: Input values did not match any of the formats where the format keyword is optional ['datetime', 'iso', 'isot', 'yday', 'datetime64', 'fits', 'byear_str', 'jyear_str']

[vn-ki]

Is it VSOClient or VSOClient()?

[yashrsharma44]

We are using an object of VSOClient()

[stale]

This pull request has been automatically marked as stale because it has not had any activity for the past five months. It will be closed if no further activity occurs. If the ideas in this pull request are still worth implementing, please make sure you open an issue to keep track of that idea!

[stale]

This pull request has been automatically closed since there was no activity for a month since it was marked as stale. If the ideas in this pull request are still worth implementing, please make sure you open an issue to keep track of that idea!