Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mocking in test_goes_ud.py to mock online tests #2962

Closed
wants to merge 8 commits into from
Closed

Added mocking in test_goes_ud.py to mock online tests #2962

wants to merge 8 commits into from

Conversation

yashrsharma44
Copy link
Member

@yashrsharma44 yashrsharma44 commented Mar 7, 2019 •
edited by nabobalis

  1. Used mocking to simulate online test
  2. Online test function to cross-check the mocking function

Partial work for #2874

@pep8speaks
Copy link

pep8speaks commented Mar 7, 2019 •
edited

Hello @yashrsharma44! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-04-03 18:57:05 UTC

@ghost
Copy link

ghost commented Mar 7, 2019 •
edited by ghost

Thanks for the pull request @yashrsharma44! Everything looks great!

@nabobalis nabobalis added this to the 1.0 milestone Mar 7, 2019
@nabobalis nabobalis added Tests Affects tests in some measure Refactoring Code changes without affecting API (generally) net Affects the net submodule labels Mar 7, 2019
@Cadair Cadair mentioned this pull request Mar 23, 2019
Open
@Cadair Cadair modified the milestones: 1.0, 1.1 May 22, 2019
@stale
Copy link

stale bot commented Oct 19, 2019

This pull request has been automatically marked as stale because it has not had any activity for the past five months. It will be closed if no further activity occurs. If the ideas in this pull request are still worth implementing, please make sure you open an issue to keep track of that idea!

@stale stale bot added the Stale The bot will close this PR after 6 months label Oct 19, 2019
@Cadair Cadair modified the milestones: 1.1, 2.0 Oct 24, 2019
@stale
Copy link

stale bot commented Nov 23, 2019

This pull request has been automatically closed since there was no activity for a month since it was marked as stale. If the ideas in this pull request are still worth implementing, please make sure you open an issue to keep track of that idea!

@stale stale bot closed this Nov 23, 2019
@nabobalis nabobalis added the Needs Adoption PRs that were abandoned but should be picked up again and merged in label Nov 23, 2019
@nabobalis nabobalis removed this from the 2.0 milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis left review comments

@vn-ki vn-ki vn-ki left review comments

Assignees
No one assigned
Labels
Needs Adoption PRs that were abandoned but should be picked up again and merged in net Affects the net submodule Refactoring Code changes without affecting API (generally) Stale The bot will close this PR after 6 months Tests Affects tests in some measure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yashrsharma44 @pep8speaks @nabobalis @vn-ki @Cadair