Added tests for sunpy/net/hek2vso/hek2vso.py

[jains8844]

Added tests for sunpy/net/hek2vso/hek2vso.py

With reference to #2970

[ghost]

Thanks for the pull request @jains8844! Everything looks great!

You just can't differentiate between a robot and the very best of humans.

[jains8844]

Why are all these checks failing ?

[nabobalis]

It would seem your changes broke something. Did you run the tests locally?

[nabobalis]

Seems like something is wrong with this fixture:

@pytest.mark.remote_data
    @pytest.fixture(scope="function")
    def h2v_client():
>       return hek2vso.H2VClient()

[jains8844]

The tests are getting passed locally for this file.

[nabobalis]

The full traceback is:

[gw0] linux -- Python 3.6.8 /home/vsts/work/1/s/.tox/conda/bin/python

    @pytest.mark.remote_data
    @pytest.fixture(scope="function")
    def h2v_client():
>       return hek2vso.H2VClient()

../.tox/conda/lib/python3.6/site-packages/sunpy/net/tests/test_hek2vso.py:36: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
../.tox/conda/lib/python3.6/site-packages/sunpy/net/hek2vso/hek2vso.py:126: in __init__
    self.vso_client = vso.VSOClient()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <sunpy.net.vso.vso.VSOClient object at 0x7f1d510fcf60>, url = None, port = None, api = None

    def __init__(self, url=None, port=None, api=None):
        api = get_online_vso_url(api, url, port)
        if api is None:
>           raise ConnectionError("Cannot find an online VSO mirror.")
E           ConnectionError: Cannot find an online VSO mirror.

If it works locally, I wonder why it fails on the servers. Can you run the test suite in tox locally and see if that errors too?

[jains8844]

Okay I'm running. Will update once I'm done with that.

[jains8844]

The tests are failing without including remote_data mark. Can't I have more than one pytest decorator for a function ?

[nabobalis]

You should be able to

[jains8844]

Yeah got it. I missed a marker for a class function.

[pep8speaks]

Hello @jains8844! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file sunpy/net/tests/test_hek2vso.py:

Line 102:1: E302 expected 2 blank lines, found 1
Line 115:1: E302 expected 2 blank lines, found 1
Line 145:1: E302 expected 2 blank lines, found 1

Comment last updated at 2019-04-08 20:49:23 UTC

[jains8844]

I've fixed the code still the checks are failing ?
The errors displayed in the checks doesn't belong to this test I guess

[nabobalis]

Yes the errors seem to be unrelated to the PR. The servers should be back now.

[jains8844]

Are there some changes required in this PR ?

[nabobalis]

Thanks @jains8844