Addressed the Issue #848 - Download data and add entries to database from a HEK query

[Ayoob7]

Addressed the Issue #848 - Download data and add entries to database from a HEK query

Description

Fixes #848

[pep8speaks]

Hello @Ayoob7! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file sunpy/database/tests/test_database.py:

Line 443:1: E302 expected 2 blank lines, found 1

Comment last updated at 2019-05-10 09:17:19 UTC

[ghost]

Thanks for the pull request @Ayoob7!

I am a bot that checks pull requests for milestones and changelog entries. If you have any questions about what I am saying, please ask!
I have the following to report on this pull request:

• I didn't detect a changelog file in this pull request. Please add a changelog file to the changelog/ directory following the instructions in the changelog README.

If there are any issues with this message, please report them here.

[nabobalis]

Hi @Ayoob7, thanks for the pull request! Could you write a test for this new code? It would go in database/tests/test_database.py.

[Ayoob7]

Hi Nabil Freij, Sure, I'll write some test cases as well. (I'm just going through the code base and familiarizing with it) Thanks for pointing in the right direction. Regards. 🙂 Ayoob

…

On Fri, Apr 19, 2019 at 6:24 PM Nabil Freij ***@***.***> wrote: Hi @Ayoob7 <https://github.com/Ayoob7>, thanks for the pull request! Could you write a test for this new code? It would go in database/tests/test_database.py. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3061 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGBE3RNDWO2ZADOQ5ZPKELDPRG6IHANCNFSM4HHD5KPQ> .

[Ayoob7]

Hi @nabobalis ,

I cant seem to install [parfive] module in my venv to run the test_database.py, when I try to install parfive in my venv, I get the following:

Exception:
Traceback (most recent call last):
  File "/home/ayoobm/Desktop/SoCIS/sunpy/venv/lib/python3.6/site-packages/pip-19.0.3-py3.6.egg/pip/_internal/cli/base_command.py", line 179, in main
    status = self.run(options, args)
  File "/home/ayoobm/Desktop/SoCIS/sunpy/venv/lib/python3.6/site-packages/pip-19.0.3-py3.6.egg/pip/_internal/commands/install.py", line 393, in run
    use_user_site=options.use_user_site,
  File "/home/ayoobm/Desktop/SoCIS/sunpy/venv/lib/python3.6/site-packages/pip-19.0.3-py3.6.egg/pip/_internal/req/__init__.py", line 57, in install_given_reqs
    **kwargs
  File "/home/ayoobm/Desktop/SoCIS/sunpy/venv/lib/python3.6/site-packages/pip-19.0.3-py3.6.egg/pip/_internal/req/req_install.py", line 913, in install
    use_user_site=use_user_site, pycompile=pycompile,
  File "/home/ayoobm/Desktop/SoCIS/sunpy/venv/lib/python3.6/site-packages/pip-19.0.3-py3.6.egg/pip/_internal/req/req_install.py", line 445, in move_wheel_files
    warn_script_location=warn_script_location,
  File "/home/ayoobm/Desktop/SoCIS/sunpy/venv/lib/python3.6/site-packages/pip-19.0.3-py3.6.egg/pip/_internal/wheel.py", line 428, in move_wheel_files
    assert info_dir, "%s .dist-info directory not found" % req
AssertionError: parfive .dist-info directory not found

I would be grateful for any Input on the problem thanks :)

[nabobalis]

How are you installing parfive?

[Ayoob7]

(pip install parfive) just as other packages I've installed like astropy

…

On 20 Apr 2019 5:52 p.m., "Nabil Freij" ***@***.***> wrote: How are you installing parfive? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3061 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGBE3RNRS45T23EKM35WRIDPRMDIZANCNFSM4HHD5KPQ> .

[nabobalis]

That's odd. I'm not aware there is an issue with installing parfive, at lest our CI seems to be ok. I've not seen that error before, I guess there might be something off with your virtual environment but I don't know what.

[Ayoob7]

Sorted, I can run the tests, I'll be adding my tests shortly. 👍 :)

[Ayoob7]

Added the test cases.

[Ayoob7]

Hey @nabobalis , made the changes as we discussed above, (removed the undo and redo methods for the database in the tests), would you be able to review my PR.
Thanks in advance.

[nabobalis]

The test fails:

  @pytest.mark.remote_data
  def test_download_from_hek_query_result(database, hek_qr, tmpdir):
E       fixture 'hek_qr' not found

I assume the fixture was not committed to the file?

[nabobalis]

What are these?

[Ayoob7]

Sorry for the late reply, I'll go through, we had an internet outage and slowdown in Sri Lanka, these are parameters for the method "download_from_vso_query_result".

[nabobalis]

That's fine, there is no rush.

If that is the case, we need to expand on these items (adding type and a description) like we have for query_result.

[dpshelio]

Suggested change

	self.download_from_vso_query_result(translated_query,path=path,progress=progress)
	self.download_from_vso_query_result(translated_query, path=path, progress=progress)

[Ayoob7]

Hi @dpshelio , made the changes for code consistency and pushed them. Would you be able to review and ratify this PR ? Thanks a bunch :)

[Ayoob7]

Hi David, Thank you working on the next issue as well. I'll keep you posted. Regards

…

On 23 May 2019 5:31 a.m., "David Pérez-Suárez" ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3061?email_source=notifications&email_token=AGBE3RLZHJRHSQNMTKF4CY3PWXNELA5CNFSM4HHD5KP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZOGBGY#pullrequestreview-240935067>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGBE3RLFYWK7YPG4X2KKVJLPWXNELANCNFSM4HHD5KPQ> .

[stale]

This pull request has been automatically marked as stale because it has not had any activity for the past five months. It will be closed if no further activity occurs. If the ideas in this pull request are still worth implementing, please make sure you open an issue to keep track of that idea!

[stale]

This pull request has been automatically closed since there was no activity for a month since it was marked as stale. If the ideas in this pull request are still worth implementing, please make sure you open an issue to keep track of that idea!