Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify definition of map.dsun #3430

Merged
merged 2 commits into from Oct 24, 2019
Merged

Conversation

dstansby
Copy link
Member

It occurred to me that "the Sun" is technically not a point, so this should read "center of the Sun".

@ghost
Copy link

ghost commented Oct 24, 2019

Thanks for the pull request @dstansby! Everything looks great!

@dstansby dstansby added the map Affects the map submodule label Oct 24, 2019
@dstansby dstansby requested a review from a team October 24, 2019 12:45
@Cadair Cadair added this to the 1.0.6 milestone Oct 24, 2019
@Cadair
Copy link
Member

Cadair commented Oct 24, 2019

"the Sun" is technically not a point

your approximations are weak 😛

@dstansby
Copy link
Member Author

"the Sun" is technically not a point

your approximations are weak 😛

I know, but I have had to go a step further and consider the Sun as a perfectly round sphere.

@dstansby dstansby closed this Oct 24, 2019
@dstansby dstansby reopened this Oct 24, 2019
@dstansby
Copy link
Member Author

Woops, did not mean to close...

@nabobalis
Copy link
Contributor

In the future a way for a bot to create a changelog entry from a commit message or title would be nice.

@dstansby
Copy link
Member Author

Yes definitely... something that can automatically be done through a comment instead of having to faff around with the source code and git again would be great.

@Cadair
Copy link
Member

Cadair commented Oct 24, 2019

Yeah I think we all had the same idea at the same time 😆

I am about 95% of the way to having rewritten sunpy bot (based on big changes to Baldrick) would be easy enough to add a command to make a changelog entry I think.

@nabobalis nabobalis merged commit 9cf5a52 into sunpy:master Oct 24, 2019
@dstansby dstansby deleted the dsun-clarify branch October 24, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map Affects the map submodule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants