Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Map plotting in user guide #3454

Merged
merged 2 commits into from Oct 29, 2019
Merged

Fixes to Map plotting in user guide #3454

merged 2 commits into from Oct 29, 2019

Conversation

ayshih
Copy link
Member

@ayshih ayshih commented Oct 28, 2019

  • Figures with multiple subplots were given insufficient size to lay out properly
  • Axes were being grabbed as non-WCSAxes axes (i.e., no projection keyword)

@ayshih ayshih added Documentation Affects the documentation map Affects the map submodule labels Oct 28, 2019
@ghost
Copy link

ghost commented Oct 28, 2019

Thanks for the pull request @ayshih! Everything looks great!

@nabobalis nabobalis added this to the 1.0.6 milestone Oct 28, 2019
@sunpy sunpy deleted a comment Oct 28, 2019
@Cadair Cadair merged commit 57f7273 into sunpy:master Oct 29, 2019
@backporting
Copy link

backporting bot commented Oct 29, 2019

The backport to 1.0 failed:

Commits ["a8030bc501942458d6a516c0c85401d72a237040","b82814c94716d10e465b2b2f49f281191c9b649e"] could not be cherry-picked on top of 1.0

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 1.0
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick a8030bc501942458d6a516c0c85401d72a237040 b82814c94716d10e465b2b2f49f281191c9b649e
# Create a new branch with these backported commits.
git checkout -b backport-3454-to-1.0
# Push it to GitHub.
git push --set-upstream origin backport-3454-to-1.0
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is 1.0 and the compare/head branch is backport-3454-to-1.0.

@Cadair Cadair added the Still Needs Manual Backport This PR needs manually backporting label Oct 29, 2019
@ayshih
Copy link
Member Author

ayshih commented Oct 29, 2019

Backport needs #3453 to be merged first

@ayshih ayshih deleted the docs branch November 7, 2019 21:22
@Cadair Cadair removed the Still Needs Manual Backport This PR needs manually backporting label Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Affects the documentation map Affects the map submodule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants