New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a helper function for testing equality/closeness of longitudes #3804
Conversation
b371446
to
0fcaa19
Compare
0fcaa19
to
48ea75b
Compare
I think this should probably go upstream to astropy, given it's non SunPy specific. |
48ea75b
to
d111b51
Compare
I don't really know what the milestone should be here? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 1.0
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick d111b51cc2ca5f74a18b099840dbb698dabfcdc0
# Create a new branch with these backported commits.
git checkout -b backport-3804-to-1.0
# Push it to GitHub.
git push --set-upstream origin backport-3804-to-1.0
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 1.1
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick d111b51cc2ca5f74a18b099840dbb698dabfcdc0
# Create a new branch with these backported commits.
git checkout -b backport-3804-to-1.1
# Push it to GitHub.
git push --set-upstream origin backport-3804-to-1.1
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
Longitude testing is a little tricky because of the wrapping. This PR creates a new function to use in tests to check for the equality/closeness of longitudes.
Should fix #3801