Improve subclassing attrs.Time and JSOC _can_handle_query #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Cadair! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-03-09 15:35:10 UTC |
Cadair
added
Needs Review
nabobalis
approved these changes
Mar 9, 2020
hayesla
approved these changes
Mar 9, 2020
|
Looks like this is good to go pending a rebase |
|
rebased. |
dpshelio
reviewed
Mar 11, 2020
Comment on lines
+872
to
+875
| if not required.issubset(query_attrs) or not query_attrs.issubset(all_attrs): | ||
| return False | ||
|
|
||
| return True |
There was a problem hiding this comment.
Suggested change
| if not required.issubset(query_attrs) or not query_attrs.issubset(all_attrs): | |
| return False | |
| return True | |
| return required.issubset(query_attrs) and query_attrs.issubset(all_attrs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a couple of small fixes from #3770
The first change is motivated by the DKIST client in DKISTDC/dkist#73 where I am subclassing
a.Timefor a different purpose. Changing our checks to be for type rather than instance means that you can combine two different subclasses of Time in one query without issue.The other is to make sure that the JSOC client can only handle queries if
a.jsoc.Seriesis provided, otherwise queries with justa.Wavelengthora.Timematch the JSOC but then .search errors.