-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contour map method #3909
Add contour map method #3909
Conversation
I think it's very useful!! Whether in the future we want these contours as RoIs and be able to extract properties based on them on other datasets is something we could discuss beyond this PR. For now, having this available simple as it's now I think is good. 👍 from me! |
I think just a small test is now needed |
I feel like this provides 90% of the functionality of compositemap. I am not complaining! Just another reason to potentially remove compositemap. Ping @Cadair. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!!!
Thanks! Since this won't make it in to 2.0 anyway, I'm waiting until I have a bit more time to add tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, but I thought we (cadair) were against adding more to the map API?
I think methods are more pythonic than functions, but happy to go either way if someone wants to make a decision. |
I'm doing some contouring at the moment, and thought a helper function might be helpful. My current use case is contouring AIA 193 maps to isolate coronal holes, and then plotting those contours on other maps.
Essentially this just uses
skimage.measure.contours
, but returns the result asSkyCoord
objects. Here is what the example I have added to the gallery looks like:Needs
Test ideas:
Sample maps with: