Fixed the observer frame attribute to always use SkyCoord-style transformation #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the
observerframe attribute where the automatic transformation toHeliographicStonyhurstwould unintentionally depend on the type of input:SkyCoord, the transformation would propagate all frame attributes (e.g.,obstime) and would work for all coordinate systems.SkyCoord, the transformation would not propagate any frame attributes. For the commonly used SunPy frames, our transformations take care of the propagation, so the result would be indistinguishable from usingSkyCoord. For the remaining SunPy frames and most Astropy frames, the transformations would error.This PR always changes the input to a
SkyCoordso that only the first path is taken and thus have there will be no transformation errors.This PR is related to code that inspired #4237, but does not fix it.