Grab bag of issues #4331

nabobalis · 2020-07-01T12:28:16Z

No description provided.

dstansby · 2020-07-04T10:32:59Z

What's the context/motivation for this?

nabobalis · 2020-07-04T11:38:18Z

The context is trying to see what happens if we unindent the retry code in the sample data to get RTD to successfully do retry on the failed sample data.

I need to rewrite more code here.

nabobalis · 2020-07-05T10:02:28Z

Seems we are failing to download the sunspot data, I am not sure why.

nabobalis · 2020-07-08T10:20:27Z

Some of this should be backported but will need to be done manually.

nabobalis · 2020-07-08T10:24:36Z

I plan to update the CI guide as well.

nabobalis · 2020-07-08T16:45:04Z

TODO:

Add tox command for using the precommit
Undo the example skip once we fix the downloader.
Add page/ Update page on our current CI.

nabobalis · 2020-07-12T13:46:35Z

On the warning for examples I can get this:

Unexpected failing examples:
/home/nabil/GitHub/sunpy/examples/map/map_data_histogram.py failed leaving traceback:
Traceback (most recent call last):
  File "/home/nabil/GitHub/sunpy/.tox/build_docs/lib/python3.8/site-packages/sphinx_gallery/gen_gallery.py", line 159, in call_memory
    return 0., func()
  File "/home/nabil/GitHub/sunpy/.tox/build_docs/lib/python3.8/site-packages/sphinx_gallery/gen_rst.py", line 466, in __call__
    exec(self.code, self.fake_main.__dict__)
  File "/home/nabil/GitHub/sunpy/examples/map/map_data_histogram.py", line 24, in <module>
    aia_smap = aia.submap(bottom_left, top_right)
  File "/home/nabil/GitHub/sunpy/.tox/build_docs/lib/python3.8/site-packages/sunpy/util/decorators.py", line 320, in inner_f
    warnings.warn(f"Pass {', '.join(args_msg)} as keyword args. "
sunpy.util.exceptions.SunpyDeprecationWarning: Pass top_right=<SkyCoord (Helioprojective: obstime=2011-06-07T06:33:02.770, rsun=696000000.0 m, observer=<HeliographicStonyhurst Coordinate (obstime=2011-06-07T06:33:02.770): (lon, lat, radius) in (deg, deg, m)
    (-0.00406308, 0.04787238, 1.51846026e+11)>): (Tx, Ty) in arcsec
    (100., 400.)> as keyword args. From version 2.1 passing these as positional arguments will result in an error.

examples/computer_vision_techniques/loop_edge_enhance.py

nabobalis · 2020-07-12T16:04:37Z

Now I can't get it to work again.

Sometimes?

nabobalis · 2020-07-12T17:15:30Z

Still getting:

DEBUG: Failed to download EVE_TIMESERIES from http://data.sunpy.org/sunpy/v1/20110607_EVE_L0CS_DIODES_1m.txt: Timeout on reading data from socket [sunpy.data._sample]
loading translations [en]... done

Task was destroyed but it is pending!
task: <Task pending name='Task-120' coro=<Downloader._write_worker() running at /home/docs/checkouts/readthedocs.org/user_builds/sunpy/conda/4331/lib/python3.8/site-packages/parfive/downloader.py:469> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x7f44e4d46250>()]>>
Exception ignored in: <coroutine object Downloader._write_worker at 0x7f44e4d441c0>
Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/sunpy/conda/4331/lib/python3.8/site-packages/parfive/downloader.py", line 469, in _write_worker
    offset, chunk = await queue.get()
  File "/home/docs/checkouts/readthedocs.org/user_builds/sunpy/conda/4331/lib/python3.8/asyncio/queues.py", line 165, in get
    getter.cancel()  # Just in case getter is not done yet.
  File "/home/docs/checkouts/readthedocs.org/user_builds/sunpy/conda/4331/lib/python3.8/asyncio/base_events.py", line 719, in call_soon
    self._check_closed()
  File "/home/docs/checkouts/readthedocs.org/user_builds/sunpy/conda/4331/lib/python3.8/asyncio/base_events.py", line 508, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
making output directory... done

nabobalis · 2020-07-13T08:31:47Z

docs/dev_guide/pr_review_procedure.rst


-* `CodeCov <https://codecov.io/gh/sunpy/sunpy/>`_: Checks how many lines of the code lack test coverage.
+* figure_report/figure_tests (Giles): Show the final results of the figure tests.


I just noticed when writing this, we have three figure giles checks.

…mal Python warning

nabobalis · 2020-07-15T10:00:20Z

docs/dev_guide/documentation.rst

+
+:meth:`numpy.ndarray.mean` but ``:func:`` will not.
+
+Never add ``:class:`` this will break the linking.


Much thanks to the MPL docs for this section.

nabobalis · 2020-07-15T13:35:35Z

.pre-commit-config.yaml

@@ -72,10 +72,10 @@ repos:
        args: ['--in-place', '--remove-all-unused-imports', '--remove-unused-variable']
        exclude: ".*(.fits|.fts|.fit|.txt|tca.*|extern.*|.rst|.md|__init__.py|sunpy/extern|docs/conf.py)$"
  - repo: https://github.com/timothycrosley/isort
-    rev: 4.3.21-2
+    rev: 5.1.0


isort update.

nabobalis · 2020-07-15T13:36:22Z

CONTRIBUTING.rst

+    sunpy is open source, under the BSD-2 license, and by contributing you are stating that you have the right to and agree to, have your work distributed under the terms of this license.
+
+    If you work at a university or research institution, you will need to check if you can contribute code you have written at work.
+    You should start by checking if there is a Open Source Software Policy (e.g., `Standford's policy <https://otl.stanford.edu/open-source-stanford>`__) for your work place.
+    If not, `OSS-Watch <http://oss-watch.ac.uk/resources/contributing>`__ summaries what you will need to check and who to ask, however this is from a UK point of view.
+    `Standford's guidance <https://otl.stanford.edu/sites/g/files/sbiybj10286/f/otlcopyrightguide.pdf>`__ for example allows someone to contribute and open source their code.
+    If you are unsure if your university or institution allows you to contribute under the BSD-2 license, you should contact the relevant department or administrator that deals with copyright.


This needs more passes and reviews. I was unsure what to suggest. I was able to find some resources but not many.

nabobalis · 2020-07-15T14:05:45Z

I might need to split this up. But I would rather not.

nabobalis · 2020-07-15T15:52:11Z

Dev build

INFO: Failed to download one or more sample data files, retrying with a mirror. [sunpy.data._sample]
Traceback (most recent call last):
  File "/home/vsts/work/1/s/examples/acquiring_data/2011_06_07_sampledata_overview.py", line 32, in <module>
    aia_cutout03_map = sunpy.map.Map(sample_data.AIA_193_CUTOUT03_IMAGE)
AttributeError: module 'sunpy.data.sample' has no attribute 'AIA_193_CUTOUT03_IMAGE'

Task was destroyed but it is pending!
task: <Task pending name='Task-131' coro=<Downloader._write_worker() running at /home/vsts/work/1/s/.tox/py38-devdeps/lib/python3.8/site-packages/parfive/downloader.py:469> wait_for=<Future pending cb=[<TaskWakeupMethWrapper object at 0x7fd3e64d3f70>()]>>
Exception ignored in: <coroutine object Downloader._write_worker at 0x7fd3e773e6c0>
Traceback (most recent call last):
  File "/home/vsts/work/1/s/.tox/py38-devdeps/lib/python3.8/site-packages/parfive/downloader.py", line 469, in _write_worker
    offset, chunk = await queue.get()
  File "/opt/hostedtoolcache/Python/3.8.3/x64/lib/python3.8/asyncio/queues.py", line 165, in get
    getter.cancel()  # Just in case getter is not done yet.
  File "/opt/hostedtoolcache/Python/3.8.3/x64/lib/python3.8/asyncio/base_events.py", line 719, in call_soon
    self._check_closed()
  File "/opt/hostedtoolcache/Python/3.8.3/x64/lib/python3.8/asyncio/base_events.py", line 508, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
ERROR: InvocationError for command /bin/bash -ec 'for f in /home/vsts/work/1/s/examples/*/*.py; do [[ $f == *skip* ]] && continue; echo $f && python $f; done' (exited with code 1)
py38-devdeps: Shutting down tox-pypi-filter server

nabobalis added this to the 2.1 milestone Jul 1, 2020

nabobalis marked this pull request as ready for review July 4, 2020 07:59

nabobalis requested a review from a team as a code owner July 4, 2020 07:59

nabobalis changed the title ~~moved retry out of loop~~ Removed retry from the sample data. Jul 5, 2020

nabobalis requested review from a team as code owners July 5, 2020 10:00

nabobalis added [CodeFix] No Changelog Entry Needed labels Jul 5, 2020

nabobalis requested a review from a team as a code owner July 8, 2020 10:19

nabobalis added the [DocFix] label Jul 8, 2020

nabobalis changed the title ~~Removed retry from the sample data.~~ Removed retry from the sample data and updated install docs Jul 8, 2020

nabobalis requested a review from a team as a code owner July 12, 2020 12:41

nabobalis commented Jul 12, 2020

View reviewed changes

examples/computer_vision_techniques/loop_edge_enhance.py Show resolved Hide resolved

nabobalis removed the No Changelog Entry Needed label Jul 12, 2020

nabobalis mentioned this pull request Jul 12, 2020

SunpyDeprecationWarnings should cause the doc build to fail #4255

Closed

nabobalis commented Jul 13, 2020

View reviewed changes

nabobalis marked this pull request as draft July 13, 2020 12:24

nabobalis added 4 commits July 15, 2020 09:33

Stopped using retry in favour of a new downloader for sample data.

230086b

updated Formatting dev docs section

562b4d2

install doc update

c6d9a9c

SunpyWarning now inherits Warning so it reports its location like nor…

136421f

…mal Python warning

nabobalis added 7 commits July 15, 2020 09:33

added t in timerange text to the main class docstring

992f59c

added tox for codestyle

b8d1af6

Sphinx tidy up

7643dae

unskip more examples

2abb7c5

expand on CI in pull request doc

1d631af

update isort

f6aa89c

updated doc dev guide

30b5f79

nabobalis commented Jul 15, 2020

View reviewed changes

nabobalis changed the title ~~Removed retry from the sample data and updated install docs~~ Grabbag of issues Jul 15, 2020

nabobalis changed the title ~~Grabbag of issues~~ Grab bag of issues Jul 15, 2020

nabobalis added 2 commits July 15, 2020 11:43

increased timeout

8718e87

Added images and text on how to read azure

adb14c7

nabobalis commented Jul 15, 2020

View reviewed changes

nabobalis closed this Jul 16, 2020

nabobalis deleted the retry branch July 16, 2020 17:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Grab bag of issues #4331

Grab bag of issues #4331

nabobalis commented Jul 1, 2020 •

edited

dstansby commented Jul 4, 2020

nabobalis commented Jul 4, 2020

nabobalis commented Jul 5, 2020

nabobalis commented Jul 8, 2020 •

edited

nabobalis commented Jul 8, 2020

nabobalis commented Jul 8, 2020 •

edited

nabobalis commented Jul 12, 2020

nabobalis commented Jul 12, 2020 •

edited

nabobalis commented Jul 12, 2020

nabobalis Jul 13, 2020

nabobalis Jul 15, 2020

nabobalis Jul 15, 2020

nabobalis Jul 15, 2020

nabobalis commented Jul 15, 2020 •

edited

nabobalis commented Jul 15, 2020


		* `CodeCov <https://codecov.io/gh/sunpy/sunpy/>`_: Checks how many lines of the code lack test coverage.
		* figure_report/figure_tests (Giles): Show the final results of the figure tests.


		:meth:`numpy.ndarray.mean` but ``:func:`` will not.

		Never add ``:class:`` this will break the linking.

Grab bag of issues #4331

Grab bag of issues #4331

Conversation

nabobalis commented Jul 1, 2020 • edited

dstansby commented Jul 4, 2020

nabobalis commented Jul 4, 2020

nabobalis commented Jul 5, 2020

nabobalis commented Jul 8, 2020 • edited

nabobalis commented Jul 8, 2020

nabobalis commented Jul 8, 2020 • edited

nabobalis commented Jul 12, 2020

nabobalis commented Jul 12, 2020 • edited

nabobalis commented Jul 12, 2020

nabobalis Jul 13, 2020

Choose a reason for hiding this comment

nabobalis Jul 15, 2020

Choose a reason for hiding this comment

nabobalis Jul 15, 2020

Choose a reason for hiding this comment

nabobalis Jul 15, 2020

Choose a reason for hiding this comment

nabobalis commented Jul 15, 2020 • edited

nabobalis commented Jul 15, 2020

nabobalis commented Jul 1, 2020 •

edited

nabobalis commented Jul 8, 2020 •

edited

nabobalis commented Jul 8, 2020 •

edited

nabobalis commented Jul 12, 2020 •

edited

nabobalis commented Jul 15, 2020 •

edited