Allow jsocClient to download .tar archives from JSOC

[lzivadinovic]

Description

This PR allows JSOCClient to download all staged files as single .tar archive while still maintaining file list in base object.

Fixes #4291

[pep8speaks]

Hello @lzivadinovic! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-02 16:23:46 UTC

[Cadair]

Thanks for opening this PR, sorry I was a bit slow getting to it. I have one major question, but otherwise it looks great.

[lzivadinovic]

I have one question regarding this PR. So, sunpy support Protocol as jsoc.attr but not Method, is there any special reason for this? It felt awkward for me to include protocol in request_data because we support it via attr, so i've omitted it. Also, if we want to support method as jsoc.attr i can add that to PR.

[Cadair]

Looks like it's basically there.

[Cadair]

We don't have to fix this here, but it feels weird that email, protocol and notify are not all the same?

[nabobalis]

Stupid question: To use fido with this, you would pass in method=url-tar to fetch?

[Cadair]

Stupid question: To use fido with this, you would pass in method=url-tar to fetch?

This doesn't add Fido support at the moment

[lzivadinovic]

Should i rebase this PR?

[Cadair]

It seems read the docs is just very upset, I think we are fine to merge this as expected fails.