Fix sphinx links in sunpy/guide #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
reviewed
Aug 7, 2020
| @@ -110,17 +110,17 @@ tags A list of :class:`tables.Tag` instances. | |||
| ``observation_time_start``, ``observation_time_end``, ``instrument``, ``size``, | |||
| ``wavemin``, and ``wavemax`` are set by methods which use the VSO interface. In | |||
| particular, these are :meth:`Database.add_from_vso_query_result`, | |||
| :meth:`Database.download` and possibly :meth:`Database.fetch`. | |||
| ``Database.download`` and possibly :meth:`Database.fetch`. | |||
There was a problem hiding this comment.
Is this not a method anymore?
There was a problem hiding this comment.
Doesn't look like it, possibly it was never a method?
There was a problem hiding this comment.
Probably best to remove it then.
nabobalis
approved these changes
Aug 7, 2020
|
Just a changelog and one question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of #4178, should fix a lot of links in the guide docs.