str function for mapbase

[sidhu1012]

Description

Fixes #4201

[sidhu1012]

Why these checks failing on such simple change

[nabobalis]

Some of those checks use servers which are prone to failing.

What does the output now look like?

A unit test would be ideal as well.

Can you also change the repr as suggested in the original issue?

[sidhu1012]

A unit test would be ideal as well.

Okay

Can you also change the repr as suggested in the original issue?

Sure

[pep8speaks]

Hello @sidhu1012! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-26 09:08:07 UTC

[nabobalis]

How do the new print and repr look on output?

[sidhu1012]

Does it seems fine now?

[nabobalis]

How do the new print and repr look on output?

[sidhu1012]

How do the new print and repr look on output?

New print :

New repr :

[nabobalis]

A changelog is required for this change.

[sidhu1012]

A changelog is required for this change.

okay

[sidhu1012]

A changelog is required for this change.

How to add changelog?

[nabobalis]

A changelog is required for this change.

How to add changelog?

Instructions are here: https://github.com/sunpy/sunpy/blob/master/changelog/README.rst

[Cadair]

Thanks for working on this @sidhu1012 it looks good 😄

[sidhu1012]

Thanks for working on this @sidhu1012 it looks good 😄

Thanks 😀

[ayshih]

Still needs a changelog entry (maybe categorized under trivial?)

[sidhu1012]

Still needs a changelog entry (maybe categorized under trivial?)

Will add it

[nabobalis]

RTD failure due to issue fixed in master.

fixed

[Cadair]

WARNING: :87: (ERROR/3) Unknown interpreted text role "method".

not sure what this is about

[Cadair]

fixed on master apparently

[sunpy-backport]

The backport to 2.0 failed:

Commits ["877250e4a4a38914363ad8af0a6387ed52ea026a","ec61c69ff0fc76d3de635f8f6f5978c7cf8222b3","8b57560225a7fadc0c0b672f21c04727bcae116e","9bdf1f752b8bf03a5dc5076487289a823bf28df6","f534637ca24224abc2e85e04886301bf189eb385","0cd62274bb0bb318a48e13b8f856c14d1e5a02e9","1ca6f1ec6ae68d7676b45480acda6ffc49a58ad0","1a8cbfa413e06862f483f2f255459695b9b3660d"] could not be cherry-picked on top of 2.0

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 2.0
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 877250e4a4a38914363ad8af0a6387ed52ea026a ec61c69ff0fc76d3de635f8f6f5978c7cf8222b3 8b57560225a7fadc0c0b672f21c04727bcae116e 9bdf1f752b8bf03a5dc5076487289a823bf28df6 f534637ca24224abc2e85e04886301bf189eb385 0cd62274bb0bb318a48e13b8f856c14d1e5a02e9 1ca6f1ec6ae68d7676b45480acda6ffc49a58ad0 1a8cbfa413e06862f483f2f255459695b9b3660d
# Create a new branch with these backported commits.
git checkout -b backport-4464-to-2.0
# Push it to GitHub.
git push --set-upstream origin backport-4464-to-2.0
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport-4464-to-2.0.

[Cadair]

Thanks a lot @sidhu1012 🚀

[dstansby]

This changes the functionality of __str__, which has caused some breakages downstream in pfsspy, meaning I'm having to pin sunpy!=2.0.2. In general I think things like this that change behaviour and are not bug-fixes shouldn't be backported, and in general we should be a bit more careful about what we're backporting.