New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4886 look for a tarball first fallback to individual files #4904
Merged
Cadair
merged 17 commits into
sunpy:master
from
samaloney:bugfix-srsclient-missing-tarball
Feb 18, 2021
Merged
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c329146
Fix #4886 look for a tarball first fallback to individual files
95ff452
Update scraper to use relativedelta not units
66513bf
Add changelog
f5d0394
Fix scraper to pass tests
9ada04f
Review updates and more test fixes
4bd556a
More scraper range fixes
83d8f4b
Fix #4886 look for a tarball first fallback to individual files
5fea615
Update scraper to use relativedelta not units
4d72bcf
Add changelog
8dbe4b6
Fix scraper to pass tests
703f56e
Review updates and more test fixes
3d210cf
More scraper range fixes
2f3d1fd
changed test and updated changelog
nabobalis 0ed1bf3
Merge branch 'bugfix-srsclient-missing-tarball' of https://github.com…
163d1ec
Rework date logic and update gong doc test.
47f0255
Update sunpy/net/dataretriever/sources/noaa.py
381a120
Apply suggestions from code review
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Fixed the `~.SRSClient` which silently failed to download the SRS files when the tarball for the previous years did not exist. | ||
Client now actually searches for the tarballs and srs files on the ftp archive before returning them as results. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the start time or end time is out of range, but not both, then the start_year or end_year variables would be
None
and would presumably fail later in this method? Do we need to clip them to the MIN_YEAR / MAX_YEAR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea that didn't catch that kind of edge case reworked and added new test for these cases.