Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regular CI to run ASV for new commits and benchmarks #4975

Merged
merged 19 commits into from Feb 22, 2021
Merged

Add regular CI to run ASV for new commits and benchmarks #4975

merged 19 commits into from Feb 22, 2021

Conversation

kathivashkiv
Copy link
Member

This is second CI for Performance Monitoring project

@kathivashkiv
Copy link
Member Author

@Cadair @nabobalis Please, have a look

@nabobalis nabobalis added Infrastructure Issues or PRs that affect the CI or packaging of SunPy No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed labels Feb 10, 2021
@nabobalis
Copy link
Contributor

Can you rebase this or merge in master?

@kathivashkiv
Copy link
Member Author

Can you rebase this or merge in master?

I tried to rebase locally. But even after resolving conflict I couldn't rebase.

@kathivashkiv
Copy link
Member Author

Can you rebase this or merge in master?

image

@nabobalis
Copy link
Contributor

Merge in master instead of a rebase.

@kathivashkiv
Copy link
Member Author

Merge in master instead of a rebase.

Where? Locally or remote? I tried to rebase locally. Sorry, I don't understand exactly what you mean

@nabobalis
Copy link
Contributor

Merge in master instead of a rebase.

Where? Locally or remote? I tried to rebase locally. Sorry, I don't understand exactly what you mean

Locally. https://stackabuse.com/git-merge-branch-into-master/ hopefully should cover it.

@kathivashkiv @Cadair
Update: change range to v2.1.dev..
b4c217e 
Co-authored-by: Stuart Mumford <stuart@cadair.com>
@kathivashkiv
Copy link
Member Author

kathivashkiv commented Feb 11, 2021 •
edited

Locally. https://stackabuse.com/git-merge-branch-into-master/ hopefully should cover it.

Thank you, now I see. But I have no master branch in my fork (both locally and remote). What should I do in this case? Create these branches?

@kathivashkiv
Copy link
Member Author

Tox codestyle:
codestyle: commands succeeded
congratulations :)

@Cadair Cadair merged commit 0e81a71 into sunpy:master Feb 22, 2021
jeffreypaul15 pushed a commit to jeffreypaul15/sunpy that referenced this pull request Mar 22, 2021
@kathivashkiv @Cadair
Add regular CI to run ASV for new commits and benchmarks (sunpy#4975)
a4f3651 
* Create a CI script to run ASV daily

* CI: write a script

* CI: update `cron`

* Add asv config file

* Add benchmarks dir

* CI: update 'cron'

* Ci: update 'cron'

* CI: change 'cron' to 7:00 UTC

* CI: add `--skip-existing-successful`option

* CI: typo fix

* Add  benchmarks file

* CI: tmp add on push activation

* Modify benchmark

* CI: final version

* Tox codestyle fix

* Update: change range to `v2.1.dev..`

Co-authored-by: Stuart Mumford <stuart@cadair.com>

* CI: typo fix and tmp on push start

* CI: delete debug step

Co-authored-by: Stuart Mumford <stuart@cadair.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadair Cadair Cadair approved these changes

Assignees
No one assigned
Labels
Infrastructure Issues or PRs that affect the CI or packaging of SunPy No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kathivashkiv @nabobalis @Cadair