[Backport 2.1] Fix #4886 look for a tarball first fallback to individual files (#4904) #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unpy#4904) * Fix sunpy#4886 look for a tarball first fallback to individual files * Update scraper to use relativedelta not units * Add changelog * Fix scraper to pass tests * Review updates and more test fixes * More scraper range fixes * Fix sunpy#4886 look for a tarball first fallback to individual files * Update scraper to use relativedelta not units * Add changelog * Fix scraper to pass tests * Review updates and more test fixes * More scraper range fixes * changed test and updated changelog * Rework date logic and update gong doc test. * Update sunpy/net/dataretriever/sources/noaa.py Co-authored-by: Nabil Freij <nabil.freij@gmail.com> * Apply suggestions from code review Co-authored-by: Stuart Mumford <stuart@cadair.com> Co-authored-by: Nabil Freij <nabil.freij@gmail.com> Co-authored-by: Stuart Mumford <stuart@cadair.com>
nabobalis
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.