Add draw_limb function #5414
Merged
Add draw_limb function #5414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
added
the
No Backport
dstansby
added
map
|
This currently depends on #5417 |
dstansby
force-pushed
the
draw-limb
branch
4 times, most recently
from
27267fc
to
33929c8
Compare
ayshih
requested changes
Sep 29, 2021
There was a problem hiding this comment.
Given that you've changed draw_limb() to return None for the hidden part of the limb when the limb is entirely visible, you really ought to also change it so that it returns None for the visible part of the limb when the limb is entirely invisible (e.g., for an observer that is on the complete opposite side of the Sun of a Helioprojective map).
Also, you forgot to add a feature changelog entry!
ayshih
approved these changes
Oct 6, 2021
Cadair
approved these changes
Oct 6, 2021
Co-authored-by: Stuart Mumford <stuart@cadair.com>
nabobalis
reviewed
Oct 6, 2021
nabobalis
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5253, and includes an example to demonstrate the new functionality. Testing is done implicitly by existing figure tests for
GenericMap.draw_limb()