Update handling of solar radius in sunpy.map #5416
Conversation
dstansby
added
the
No Backport
changelog/xxxx.feature.rst
Outdated
| @@ -0,0 +1,3 @@ | |||
| `sunpy.map.GenericMap.rsun_meters` now uses `sunpy.map.GenericMap.rsun_obs` | |||
| as a fallback to calculate the radial distance if RSUN_REF metadata isn't | |||
There was a problem hiding this comment.
"radial distance" is potentially confusing, since a reader may think you mean the Sun-observer distance (which is the radius in HeliographicStonyhurst).
There was a problem hiding this comment.
👍 , I also changed the property docstring slightly, and went with "assumed radius of observed emission". Other suggestions welcome.
sunpy/coordinates/sun.py
Outdated
| @@ -70,6 +70,11 @@ def _angular_radius(sol_radius, distance): | |||
| return Angle(solar_semidiameter_rad.to(u.arcsec)) | |||
|
|
|||
|
|
|||
| @u.quantity_input | |||
| def _radius(angular_radius: u.arcsec, distance: u.m): | |||
There was a problem hiding this comment.
I suggest being more verbose in the name of this function, e.g., _physical_radius_from_angular_radius()
There was a problem hiding this comment.
👍 - I went with _radius_from_angular_radius, but happy to go more explicit again and put physical at the front.
dstansby
force-pushed
the
rsun
branch
2 times, most recently
from
9fbbe5b
to
360ad40
Compare
dstansby
force-pushed
the
rsun
branch
3 times, most recently
from
70679fd
to
b7306d1
Compare
|
Hello @dstansby! Thanks for updating this PR.
Comment last updated at 2021-07-10 11:33:09 UTC |
nabobalis
added
Needs Review
This cleans up handling of
rsun_obsandrsun_metersso:rsun_meters.rsun_meterscan now rely onrsun_obsmetadata to calculate a value, if presentwarningtolog.debug? #5285