Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to use carrington coordinates with draw_grid() #5703

Merged
merged 4 commits into from Apr 7, 2022
Merged

Add option to use carrington coordinates with draw_grid() #5703

merged 4 commits into from Apr 7, 2022

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Nov 16, 2021 •
edited

Fixes #5596. Comments very welcome on the new API.

@dstansby dstansby added the No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) label Nov 16, 2021
@dstansby dstansby added the Whats New? Needs a section added to the current Whats New? page. label Jan 18, 2022
@dstansby dstansby added this to the 4.0.0 milestone Feb 15, 2022
@dstansby dstansby force-pushed the draw_grid_car branch 2 times, most recently from b367cf8 to 7a5a7a2 Compare February 15, 2022 18:50
@dstansby dstansby marked this pull request as ready for review February 15, 2022 18:50
@dstansby dstansby requested review from a team as code owners February 15, 2022 18:50
@dstansby dstansby added the Needs Review Needs reviews before merge label Feb 15, 2022
ayshih
ayshih requested changes Mar 17, 2022
View reviewed changes
changelog/5703.feature.rst Outdated Show resolved Hide resolved
docs/whatsnew/4.0.rst Show resolved Hide resolved
examples/plotting/grid_plotting.py Show resolved Hide resolved
sunpy/visualization/wcsaxes_compat.py Outdated Show resolved Hide resolved
@dstansby dstansby force-pushed the draw_grid_car branch 2 times, most recently from a71bfea to d18b709 Compare March 17, 2022 19:28
@dstansby dstansby requested a review from ayshih March 21, 2022 16:34
@nabobalis nabobalis removed request for a team April 6, 2022 04:46
ayshih
ayshih requested changes Apr 6, 2022
View reviewed changes
Copy link
Member

@ayshih ayshih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more changes

docs/whatsnew/4.0.rst Outdated Show resolved Hide resolved
examples/plotting/grid_plotting.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Apr 6, 2022
View reviewed changes
sunpy/map/mapbase.py Outdated Show resolved Hide resolved
@nabobalis nabobalis requested a review from ayshih April 6, 2022 16:26
ayshih
ayshih approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@ayshih ayshih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more fix, and I think it's good to go

sunpy/map/mapbase.py Outdated Show resolved Hide resolved
@nabobalis @ayshih
Update sunpy/map/mapbase.py
38326c0 
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
@nabobalis nabobalis removed the Needs Review Needs reviews before merge label Apr 7, 2022
@nabobalis nabobalis added the Merge When CI Passes Hit that merge button when it's all green! label Apr 7, 2022
@nabobalis nabobalis merged commit 9826116 into sunpy:main Apr 7, 2022
@dstansby dstansby deleted the draw_grid_car branch May 14, 2022 08:27
@dstansby dstansby removed the Whats New? Needs a section added to the current Whats New? page. label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConorMacBride ConorMacBride ConorMacBride left review comments

@ayshih ayshih ayshih approved these changes

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
Merge When CI Passes Hit that merge button when it's all green! No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Add Carrington coordinate option to draw_grid
4 participants
@dstansby @ayshih @nabobalis @ConorMacBride