Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all usage of distutils as it is now deprecated #5713

Merged
merged 2 commits into from Nov 19, 2021

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Nov 19, 2021

Description

Fixes #

@dstansby
Copy link
Member

I'm guessing this is worth backporting? It does introduce a new runtime dependency though...

@Cadair
Copy link
Member Author

Cadair commented Nov 19, 2021

We could get away without backporting it, but it's probably a good idea. It should be noted that astropy has also introduced this runtime dep as well.

Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add a changelog to notify users of the new dependency, even if it is likely that they already have it installed.

Copy link
Contributor

@nabobalis nabobalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog has been added.

@nabobalis nabobalis added the Merge When CI Passes Hit that merge button when it's all green! label Nov 19, 2021
@nabobalis nabobalis merged commit 0070bd3 into sunpy:main Nov 19, 2021
@sunpy-backport
Copy link

The backport to 3.0 failed:

Commits ["c621050b49f220ca7baeca8a1d7bd0c2e32217d4","9868e343a3a39aea6046e67b7fdef68bd499c99d"] could not be cherry-picked on top of 3.0

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 3.0
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick c621050b49f220ca7baeca8a1d7bd0c2e32217d4 9868e343a3a39aea6046e67b7fdef68bd499c99d
# Create a new branch with these backported commits.
git checkout -b backport-5713-to-3.0
# Push it to GitHub.
git push --set-upstream origin backport-5713-to-3.0
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is 3.0 and the compare/head branch is backport-5713-to-3.0.

@nabobalis
Copy link
Contributor

Backported to 3.0 manually.

@Cadair Cadair deleted the no_distutils branch November 22, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge When CI Passes Hit that merge button when it's all green!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants