max conns to JSOC is always 1

[nabobalis]

No description provided.

[wtbarnes]

It seems a bit extreme to force only 1 max_split and max_conn. Is it possible to just make the defaults 1?

[nabobalis]

JSOC say it should only be one and I think we should not let users change this.

[Cadair]

I would like to consider the knock-on impacts this has on mixed-client downloads and the general poor experience for people who are now used to parallel downloads even when just downloading from JSOC.

[Cadair]

I am treating this as a bugfix for backporting, if we merge this then a second PR actually removing all these kwargs needs opening.

As this is (with out the max_conn setting through Fido) I am 👍 on this, I have no issue with completely disabling chunked downloads for JSOC at their behest.

That being said, I do wonder if there is any point in the max_conn changes in this PR, as it only affects people directly using the JSOCClient, and it's easy to override even for them by passing through a new Downloader object. Why don't we just remove that option in a not-backport PR by pulling the keyword arg completely?

[Cadair]

To be clear, the proper long term fix here is Cadair/parfive#39 where the JSOCClient can say to parfive "only one connection at once to jsoc.stanford.edu please" and it can have 10,000 open connections to somewhere else at the same time for all JSOCClient cares.

[wtbarnes]

To be clear, the proper long term fix here is Cadair/parfive#39 where the JSOCClient can say to parfive "only one connection at once to jsoc.stanford.edu please" and it can have 10,000 open connections to somewhere else at the same time for all JSOCClient cares.

Is there any reason to not wait on that fix then and just pin to the latest version of parfive or higher?

EDIT: I thought that was a PR, but it is just an issue 😅

[nabobalis]

That being said, I do wonder if there is any point in the max_conn changes in this PR, as it only affects people directly using the JSOCClient, and it's easy to override even for them by passing through a new Downloader object. Why don't we just remove that option in a not-backport PR by pulling the keyword arg completely?

You mean remove the keyword in the fetch for jsoc or in the downloader?

[nabobalis]

I will manually backport to each.