Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a policy on supported test dependencies #5926

Merged
merged 1 commit into from Mar 2, 2022

Conversation

dstansby
Copy link
Member

@dstansby dstansby commented Mar 2, 2022

It's probably useful to have this whilst fighting the 🗑️ 🔥 that is our CI at the moment. I think 12 months strikes a good balance between us not having to support too many versions and others (especially packagers) having to have the latest version available.

@dstansby dstansby requested a review from a team as a code owner March 2, 2022 09:51
@dstansby dstansby added backport 3.0 Documentation Affects the documentation Tests Affects tests in some measure labels Mar 2, 2022
@dstansby dstansby added the Needs Review Needs reviews before merge label Mar 2, 2022
@ConorMacBride
Copy link
Member

Merge or discuss more later?

@nabobalis nabobalis merged commit 93c5fc0 into sunpy:main Mar 2, 2022
@sunpy-backport
Copy link

sunpy-backport bot commented Mar 2, 2022

The backport to 3.0 failed:

Commits ["5b49179b24aa578bbee9ad9c16219ce03de02e73"] could not be cherry-picked on top of 3.0

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 3.0
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 5b49179b24aa578bbee9ad9c16219ce03de02e73
# Create a new branch with these backported commits.
git checkout -b backport-5926-to-3.0
# Push it to GitHub.
git push --set-upstream origin backport-5926-to-3.0
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is 3.0 and the compare/head branch is backport-5926-to-3.0.

@dstansby dstansby deleted the mindeps-policy branch March 2, 2022 16:34
@nabobalis nabobalis removed the Needs Review Needs reviews before merge label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Affects the documentation Tests Affects tests in some measure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants