Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport GitHub Actions to 3.0 #6004

Merged
merged 17 commits into from
Mar 24, 2022

Conversation

ConorMacBride
Copy link
Member

@ConorMacBride ConorMacBride commented Mar 24, 2022

  • Check that tox envs match

# Conflicts:
#	azure-pipelines.yml
# Conflicts:
#	.github/workflows/tests.yml
#	azure-pipelines.yml
Build arm64 instead of universal2 mainly because this is what astropy does. As the package manager can automatically choose the platform for the user there are few benefits of having the 2 in 1 solution. We would still need to provide a specific macOS x86_64 wheel anyway as iirc older pip versions can't install universal2 wheels.

# Conflicts:
#	.github/workflows/ci.yml
# Conflicts:
#	.github/workflows/ci.yml
# Conflicts:
#	.github/workflows/ci.yml
# Conflicts:
#	docs/dev_guide/contents/pr_review_procedure.rst
Scheduled workflow runs are triggered through a separate workflow which uses the GitHub CLI to trigger workflow runs on specific branches. (Because schedules on work on the default branch.) Therefore, the github.event in the ci.yml workflow is actually workflow_dispatch (i.e. manually triggered) rather than schedule.
@ConorMacBride ConorMacBride added No Changelog Entry Needed No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) labels Mar 24, 2022
@ConorMacBride ConorMacBride added this to the 3.0.7 milestone Mar 24, 2022
@ConorMacBride ConorMacBride requested a review from a team as a code owner March 24, 2022 11:12
@ConorMacBride ConorMacBride merged commit 9d1a7e9 into sunpy:3.0 Mar 24, 2022
@ConorMacBride ConorMacBride deleted the backport-gha-to-3.0 branch March 24, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants