-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport GitHub Actions to 3.0 #6004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ConorMacBride
commented
Mar 24, 2022
•
edited
edited
- Check that tox envs match
# Conflicts: # azure-pipelines.yml
# Conflicts: # .github/workflows/tests.yml # azure-pipelines.yml
Build arm64 instead of universal2 mainly because this is what astropy does. As the package manager can automatically choose the platform for the user there are few benefits of having the 2 in 1 solution. We would still need to provide a specific macOS x86_64 wheel anyway as iirc older pip versions can't install universal2 wheels. # Conflicts: # .github/workflows/ci.yml
# Conflicts: # .github/workflows/ci.yml
# Conflicts: # .github/workflows/ci.yml
# Conflicts: # docs/dev_guide/contents/pr_review_procedure.rst
Scheduled workflow runs are triggered through a separate workflow which uses the GitHub CLI to trigger workflow runs on specific branches. (Because schedules on work on the default branch.) Therefore, the github.event in the ci.yml workflow is actually workflow_dispatch (i.e. manually triggered) rather than schedule.
ConorMacBride
added
No Changelog Entry Needed
No Backport
A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
labels
Mar 24, 2022
nabobalis
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
No Backport
A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
No Changelog Entry Needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.