Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test data cleanup #6065

Merged
merged 37 commits into from
Apr 27, 2022
Merged

Test data cleanup #6065

merged 37 commits into from
Apr 27, 2022

Conversation

dstansby
Copy link
Member

This is a rebase and of #5261, with outstanding tasks in that PR done. I'm opening a new PR as I didn't want to force push the rebase in case something went wrong somewhere... Thanks to @wtbarnes for doing 99% of this work!

Fixes #5247
Fixes #4823
Fixes #1686
Fixes #5504

@dstansby dstansby requested review from a team as code owners April 12, 2022 16:59
@dstansby dstansby mentioned this pull request Apr 12, 2022
Closed
12 tasks
@nabobalis nabobalis removed request for a team April 13, 2022 04:00
@nabobalis
Copy link
Contributor

So in summary all the test files are now headers expect:

  1. AIA 171
  2. EIT
  3. HMI
  4. what else?

@nabobalis nabobalis added the Needs Review Needs reviews before merge label Apr 22, 2022
@dstansby dstansby added the No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) label Apr 23, 2022
@nabobalis
Copy link
Contributor

I think for a future PR, we will want to create a dev doc on this approach, how to use it, what real data exist, what header files we have etc.

@wtbarnes
Copy link
Member

So in summary all the test files are now headers expect:

1. AIA 171

2. EIT

3. HMI

4. what else?

RHESSI

wtbarnes
wtbarnes approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed up a few minor things and everything else looks good to me. Thanks @dstansby for pushing this over the line after I ran out of motivation!

Someone else should probably review this as well given that I am the primary author.

@wtbarnes wtbarnes merged commit 8481a26 into sunpy:main Apr 27, 2022
@wtbarnes wtbarnes mentioned this pull request Apr 27, 2022
Open
@dstansby dstansby deleted the test-data-cleanup branch August 2, 2022 22:03
@nabobalis nabobalis removed the Needs Review Needs reviews before merge label Aug 3, 2022
@Cadair Cadair mentioned this pull request Aug 3, 2022
Merged
@ayshih ayshih mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

@wtbarnes wtbarnes wtbarnes approved these changes

Assignees
No one assigned
Labels
No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed
Projects
None yet
Milestone
No milestone
3 participants
@dstansby @nabobalis @wtbarnes