Improve performance of timerange extraction in scraper #6101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
force-pushed
the
scraper-perf
branch
2 times, most recently
from
4d48739
to
a55f245
Compare
|
This looks great - I have a vague recollection of something about leap seconds which was why we use |
nabobalis
approved these changes
Apr 26, 2022
|
pre-commit.ci autofix |
nabobalis
added
the
Merge When CI Passes
for more information, see https://pre-commit.ci
|
The SRS remote tests are failing on main. Otherwise the other online fails are flaky ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was digging into why some SUVI tests take so long to run (even with
vcrpy, ie. ignoring the remote response times), and when there are a lot of URLs to parse,get_timerange_from_exdictis the bottleneck, as it is run on every URL. Most of the time was spent inastropy.time.Timelogic, but this is unnesseary as this code doesn't use any special features ofTime, so:datetimeifstatements so they're not all executed if seconds are specified in the timestampThis leads to a ~50% improvement in running the scraper for me. On some SUVI searches in the current test suite, this reudces their runtime by ~3 seconds.