Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sphinx_panels -> sphinx_design #6271

Merged
merged 1 commit into from Jun 20, 2022
Merged

sphinx_panels -> sphinx_design #6271

merged 1 commit into from Jun 20, 2022

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Jun 19, 2022

Fixes #6270

The CSS isn't the same, something we will need to tweak I think in our theme.

Untitled

Built with Sphinx 5.0.2 as well now.

@nabobalis nabobalis marked this pull request as ready for review June 19, 2022 21:32
@nabobalis nabobalis requested a review from a team as a code owner June 19, 2022 21:32
.. toctree::
:maxdepth: 3

contents/newcomers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this at a depth of 3 looks odd, but beyond scope of this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason that i picked it, is that the box looks a bit empty if I set it to 1. Almost like it doesn't need a box.

@Cadair Cadair merged commit f57d58a into sunpy:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from sphinx-panels to sphinx-design
3 participants