Implement a cgi alive test when determining what VSO endpoint to use #6362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
commented
Aug 15, 2022
|
Thanks for this, very edge case but frustrating to encounter. 👍 |
Cadair
force-pushed
the
zeep_service_url_test
branch
from
9c18e79
to
a013792
Compare
dstansby
previously requested changes
Aug 16, 2022
|
Nudge - I'm happy to try and finish this up @Cadair if you don't have time? |
nabobalis
added
Minor Change
nabobalis
force-pushed
the
zeep_service_url_test
branch
from
bd79c05
to
02645da
Compare
|
I wasn't sure what was left for this but I rebased and added some mock tests for the new functions. I think a better mocked test would be to make the first urlopen fail then see if it connects to a second URL later on as a real remote test. |
Cadair
force-pushed
the
zeep_service_url_test
branch
from
02645da
to
4c7ff5d
Compare
Cadair
force-pushed
the
zeep_service_url_test
branch
from
4c7ff5d
to
e59d017
Compare
Cadair
force-pushed
the
zeep_service_url_test
branch
from
bdb06d6
to
ac5a74d
Compare
|
The online test fails are unrelated |
nabobalis
reviewed
Apr 26, 2023
nabobalis
approved these changes
Apr 26, 2023
|
LGTM, shall we merge? |
nabobalis
added
backport 5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6361
I have no idea how to test this, as we are testing that a url in a remote file is accessible. I guess the only way would be to trick the function into downloading a pre-faked WSDL file.