Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin version of jsonschema #6366

Merged
merged 1 commit into from
Aug 16, 2022
Merged

pin version of jsonschema #6366

merged 1 commit into from
Aug 16, 2022
+1 −0

Conversation

nabobalis
Copy link
Contributor

No description provided.

@nabobalis nabobalis added No Changelog Entry Needed CodeFix Merge When CI Passes Hit that merge button when it's all green! labels Aug 16, 2022
@ConorMacBride
Copy link
Member

Should we just wait for the fix in asdf? asdf-format/asdf#1172

@nabobalis
Copy link
Contributor Author

My feeling is that python-jsonschema/jsonschema#981 is going to take some time, so we might as well restore our CI until then.

@nabobalis
Copy link
Contributor Author

Reverting this PR tomorrow or in 6 hours won't take too much effort either.

@ConorMacBride
Copy link
Member

Yeah, it might take some time. I didn't see the jsonschema issue

@ConorMacBride ConorMacBride merged commit 7d6db92 into sunpy:main Aug 16, 2022
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Aug 16, 2022
@ConorMacBride @meeseeksmachine
Backport PR sunpy#6366: pin version of jsonschema
770d87f
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 16, 2022
Merged
@nabobalis nabobalis deleted the ci branch August 16, 2022 23:16
@nabobalis
Copy link
Contributor Author

Thanks.

@Cadair
Copy link
Member

Cadair commented Aug 17, 2022

My understanding of test package pins was that there was only one copy on main that everything uses so this wouldn't have needed back porting. However, I see that's not true. If we change the tox.ini file to use the URL version of the file (like we do in ndcube) then we only need to maintain a single version of this?

@nabobalis
Copy link
Contributor Author

nabobalis commented Aug 17, 2022 •
edited

Right, we should do that and done.

@WilliamJamieson
Copy link
Contributor

ASDF 2.12.1 and 2.11.2 have been released which pin jsonschema inside them. You may want to update your pins to use them now.

@nabobalis
Copy link
Contributor Author

ASDF 2.12.1 and 2.11.2 have been released which pin jsonschema inside them. You may want to update your pins to use them now.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConorMacBride ConorMacBride ConorMacBride approved these changes

Assignees
No one assigned
Labels
Merge When CI Passes Hit that merge button when it's all green! No Changelog Entry Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nabobalis @ConorMacBride @Cadair @WilliamJamieson