Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HMI download and update cutout example to remove first image download #6511

Merged
merged 6 commits into from
Oct 28, 2022
Merged

Remove HMI download and update cutout example to remove first image download #6511

merged 6 commits into from
Oct 28, 2022

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Oct 26, 2022 •
edited

Fixes #6510
Fixes #6146

@nabobalis nabobalis added Documentation Affects the documentation DocFix labels Oct 26, 2022
@nabobalis nabobalis requested a review from a team as a code owner October 26, 2022 16:51
@dstansby
Copy link
Member

This should get two reviews!

@dstansby dstansby removed the DocFix label Oct 27, 2022
@nabobalis
Copy link
Contributor Author

Gallery thumbnail is now back.

wtbarnes
wtbarnes reviewed Oct 27, 2022
View reviewed changes
examples/acquiring_data/downloading_cutouts.py Outdated
files = Fido.fetch(query)
files.sort()

#####################################################
# Now that we've downloaded the files, we can create
# a `~sunpy.map.MapSequence` from them and animate
# them.

sequence = sunpy.map.Map(files, sequence=True)
# Make sure the colorbar limits are the same for each image
for each_map in sequence:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're here, can you remove this for loop and just put the norm= directly in the sequence.plot call? When I first wrote this example, that didn't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give me a minute.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

wtbarnes
wtbarnes approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One peripheral change, but otherwise looks good to me.

@nabobalis nabobalis changed the title Remove HMI download and update cutout time Remove HMI download and update cutout example to remove first image download Oct 27, 2022
@nabobalis nabobalis merged commit 8c0b905 into sunpy:main Oct 28, 2022
@nabobalis nabobalis deleted the example branch October 28, 2022 00:33
@lumberbot-app
Copy link

lumberbot-app bot commented Oct 28, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 4.0
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 8c0b9054dc25918ee5b6286a93edbbca09cde903
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #6511: Remove HMI download and update cutout example to remove first image download'
  1. Push to a named branch:
git push YOURFORK 4.0:auto-backport-of-pr-6511-on-4.0
  1. Create a PR against branch 4.0, I would have named this PR:

"Backport PR #6511 on branch 4.0 (Remove HMI download and update cutout example to remove first image download)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@lumberbot-app lumberbot-app bot added the Still Needs Manual Backport This PR needs manually backporting label Oct 28, 2022
@nabobalis nabobalis removed the Still Needs Manual Backport This PR needs manually backporting label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

@wtbarnes wtbarnes wtbarnes approved these changes

Assignees
No one assigned
Labels
Documentation Affects the documentation No Changelog Entry Needed
Projects
None yet
Milestone
No milestone
3 participants
@nabobalis @dstansby @wtbarnes