Fixing issues related to tox-conda #6521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Python version" This reverts commit e75e4da.
ayshih
added
Tests
ayshih
force-pushed
the
more-tox-conda
branch
from
b73fc04
to
2a924a2
Compare
ayshih
force-pushed
the
more-tox-conda
branch
from
2a924a2
to
9d7836f
Compare
ayshih
force-pushed
the
more-tox-conda
branch
from
9d7836f
to
0388a0a
Compare
| @@ -35,6 +35,7 @@ dependencies: | |||
| # Testing | |||
| - hypothesis | |||
| - pytest | |||
| - pytest-arraydiff | |||
There was a problem hiding this comment.
This also needs to be enabled by passing --arraydiff to the pytest command.
There was a problem hiding this comment.
I'm adding it to the environment file to be explicit. It's already a dependency in truth - the pytest mark would not be defined otherwise - but we never encountered an issue because the dependency will always be satisfied due to pytest-astropy having it as a dependency. Thus, adding it to the environment file doesn't actually change the environment because it's already installed anyway.
Actually enabling it our tox commands requires me to fix that one test, which I will get to in a separate PR.
nabobalis
approved these changes
Oct 31, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our cron CI builds between the 25th and the 27th this past week,
pytestwent from 7.1.3 to 7.2.0 andtoxwent from 3.26.0 to 3.27.0, but alsotox-condawent from 0.9.2 to 0.10.0. Probably due to the newtox-condarelease, but maybe due to something else, ourpy39-condabuild is once again running Python 3.10 instead of the intended 3.9. This PR reverts my workaround in #6494, and as predicted in that PR, the newtox-condarelease no longer needs to be worked around.Also, adding
pytest-arraydiffas a direct dependency (it was already an indirect dependency throughpytest-astropy)Also, pinning
pytestandpytest-xdista la #6508 (see also #6505)Also, adding
hvpyas a dependency, viapipuntil it is available onconda-forge.hvpyhas a dependency (pydantic) that is not otherwise installed in the conda environment, so temporarily explicitly installpydantic.