Re-enabled the use of pytest-arraydiff #6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayshih
added
Tests
dstansby
approved these changes
Oct 31, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Oct 31, 2022
|
I should have approved this first, but take me merging it as an approval 🙈 |
dstansby
added a commit
that referenced
this pull request
Oct 31, 2022
…3-on-4.0 Backport PR #6523 on branch 4.0 (Re-enabled the use of pytest-arraydiff)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #6505, at some point we unintentionally omitted enabling the array comparison of
pytest-arraydiff, via the--arraydiffoption. Thus, we missed that our one array-comparison test should have been failing and needed to be updated. This PR fixes both things.