LASCO_tutorials_and_masking #6576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwhv2 are you looking for comments on this? Just wanted to check since it's in draft state |
|
@dstansby I was correcting some of the CI issues before marking it ready. Otherwise, yes! Below are screenshots of the plots produced in the two tutorials. |
nabobalis
reviewed
Feb 2, 2023
|
Sorry it took so long for a review @mwhv2 |
|
Can you merge in main please? Hopefully that will fix the failing checks. |
nabobalis
reviewed
Feb 5, 2023
nabobalis
reviewed
Feb 5, 2023
|
Thanks for the fixes @mwhv2, I will try to get others to review this soon. |
dstansby
requested changes
Mar 14, 2023
nabobalis
force-pushed
the
LASCO_tutorials
branch
from
e3fa537
to
fae3eb4
Compare
nabobalis
force-pushed
the
LASCO_tutorials
branch
from
fae3eb4
to
27f66e3
Compare
|
I rebased the PR and fixed hopefully the last few review comments. |
nabobalis
approved these changes
Mar 24, 2023
dstansby
requested changes
Apr 19, 2023
Adds two LASCO tutorials to the example gallery. mask_occulter creates masks for LASCO C2 and C3 maps.
Co-authored-by: David Stansby <dstansby@gmail.com>
nabobalis
force-pushed
the
LASCO_tutorials
branch
from
a57a0b2
to
60ea242
Compare
|
I rebased just to make sure the CI is passing, considering how on fire it has been recently. |
dstansby
approved these changes
Apr 23, 2023
dstansby
added
the
No Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #6420 and fixes #3098. The tutorial lasco_overlay.py demonstrates the process required to overlay an AIA image onto a processed LASCO C2 image. It doubles as an example to show the usage of hvpy, since the Helioviewer Client is deprecated (#6404).
The tutorial lasco_mask.py is partly based upon a script by @AlthKouloumvakos (in #3098) that shows how to create a custom mask for an unprocessed LASCO C2 image that is downloaded using Fido. Overall, this tutorial combines elements from the current two masking tutorials and could help serve as a guide for creating custom masks.
I have also added the process from the lasco_mask tutorial as a property in the LASCO subclass. This allows a user to generate a LACSO mask (e.g., using
mask = lasco.mask_occulter) which they can then apply to theirMap. The bounds I have set for the LASCO C2 mask is based on the specified field of view, as well as in comparison to LASCO C2 data in HelioViewer. C3 data uses the mask recommended in LASCO calibration directory (this way the occulter pylon is also masked). I have not found many examples of LASCO C1 data, so I have not added a mask for this detector (but I would be happy to add one).