Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update self_test #6600

Merged
merged 6 commits into from Nov 17, 2022
Merged

Update self_test #6600

merged 6 commits into from Nov 17, 2022

Conversation

nabobalis
Copy link
Contributor

  1. Non-zero return
  2. Allow python -m sunpy.tests.self_test

@nabobalis nabobalis added Tests Affects tests in some measure No Changelog Entry Needed Infrastructure Issues or PRs that affect the CI or packaging of SunPy No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Run cron CI Run cron CI on this PR labels Nov 12, 2022
@nabobalis nabobalis closed this Nov 12, 2022
@nabobalis nabobalis reopened this Nov 12, 2022
sunpy/tests/self_test.py Outdated Show resolved Hide resolved
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only remaining comment is if it's worth running this as part of our CI?

Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so I tested this locally and it dosen't seem to work if you run it outside of the source checkout:

python -m "sunpy.tests.self_test"



Starting sunpy self test...
Checking for packages needed to run sunpy:
All required and optional sunpy dependencies are installed.
Starting the sunpy test suite:

==================================================================================== test session starts =====================================================================================
platform linux -- Python 3.10.8, pytest-7.1.1, pluggy-1.0.0
Matplotlib: 3.6.1
Freetype: 2.6.1
rootdir: /home/stuart
plugins: remotedata-0.3.3, openfiles-0.5.0, mock-3.7.0, filter-subpackage-0.1.1, doctestplus-0.12.0, cov-3.0.0, astropy-header-0.2.1, arraydiff-0.5.0, hypothesis-6.39.4, mpl-0.14.0, intercept-remote-1.25, asdf-2.11.0, forked-1.4.0, xdist-2.5.0, napari-plugin-engine-0.2.0, npe2-0.6.1, napari-0.4.16, astropy-0.10.0
collected 0 items                                                                                                                                                                            

=================================================================================== no tests ran in 0.47s ====================================================================================

@nabobalis
Copy link
Contributor Author

nabobalis commented Nov 14, 2022

That is odd, before I did the last commit, I tested it outside of the repo and it did run for me.
I'll debug.

@nabobalis
Copy link
Contributor Author

nabobalis commented Nov 15, 2022

Oh I think I know what it is, did you remove the sunpy directory from your home directory?

Not sure how to work around that.

@Cadair Cadair merged commit 557a7bf into sunpy:main Nov 17, 2022
@nabobalis nabobalis deleted the test branch November 17, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues or PRs that affect the CI or packaging of SunPy No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) Run cron CI Run cron CI on this PR Tests Affects tests in some measure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants