Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exposure time bug #6637

Merged
merged 2 commits into from Nov 28, 2022
Merged

Fix exposure time bug #6637

merged 2 commits into from Nov 28, 2022

Conversation

wtbarnes
Copy link
Member

This PR fixes a bug where when the exposure time was set to zero, the exposure_time property on Map returned None. This can be seen in some of the aiapy test failures: https://gitlab.com/wtbarnes/aiapy/-/jobs/3389796025#L145

@wtbarnes wtbarnes requested a review from a team as a code owner November 28, 2022 18:46
@nabobalis
Copy link
Contributor

Will this need backporting to 4.1 or 4.0?

@nabobalis nabobalis added BugFix map Affects the map submodule labels Nov 28, 2022
@wtbarnes
Copy link
Member Author

Will this need backporting to 4.1 or 4.0?

Just 4.1

@dstansby dstansby merged commit acefd81 into sunpy:main Nov 28, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Nov 28, 2022

Oops, something went wrong applying the patch ... Please have a look at my logs.

@wtbarnes
Copy link
Member Author

wait, neither! It did not make it into 4.1

@nabobalis nabobalis added the No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map Affects the map submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants