Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newcomers.rst #6718

Merged
merged 3 commits into from Jan 20, 2023
Merged

Update newcomers.rst #6718

merged 3 commits into from Jan 20, 2023

Conversation

ryuusama09
Copy link
Contributor

Thank you for contributing to SunPy

🚨 IMPORTANT 🚨

We know that working on code and submitting pull requests takes effort, and we appreciate your time.
Thank you.

Please be aware that everyone has to follow our code of conduct

Furthermore, you might need to check with your work place if you are allowed to contribute code

  • Please try to create an issue before creating a Pull Request.
  • Please use the following Git commit message style
    • Use the future tense ("Adds feature" not "Added feature")
    • Limit the first line to 72 characters or less

We have several automatic features that run when a pull request is open.
They can appear daunting but do not worry about them!
This a brief explanation of them.

β†‘πŸ‘† DELETE above before submitting πŸ‘†β†‘

PR Description

aadded the link to community forum in newcomers.rst

@ryuusama09 ryuusama09 requested a review from a team as a code owner January 19, 2023 06:32
@ryuusama09
Copy link
Contributor Author

@nabobalis , removed the old commits

@nabobalis nabobalis added DocFix No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed labels Jan 19, 2023
@nabobalis
Copy link
Contributor

I think the original issue wanted these links added to some key places in the documentation as well.

Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
@ryuusama09
Copy link
Contributor Author

I think the original issue wanted these links added to some key places in the documentation as well.

umm , should we add them to the main sunpy readme ?

@nabobalis
Copy link
Contributor

umm , should we add them to the main sunpy readme ?

I think the original issue had a few ideas.

The main readme should have them if they are missing from it but that is not part of the documentation.

@ryuusama09
Copy link
Contributor Author

ryuusama09 commented Jan 19, 2023

umm , should we add them to the main sunpy readme ?

I think the original issue had a few ideas.

The main readme should have them if they are missing from it but that is not part of the documentation.

it only mentions the example gallery . If you have any ideas then i can add the links over there as well.
@nabobalis , any update ?

@ryuusama09
Copy link
Contributor Author

umm , should we add them to the main sunpy readme ?

I think the original issue had a few ideas.

The main readme should have them if they are missing from it but that is not part of the documentation.

umm , should we add them to the main sunpy readme ?

I think the original issue had a few ideas.

The main readme should have them if they are missing from it but that is not part of the documentation.

@nabobalis , the main readme has links for chat and mailing list , but lacks the link for community forum . Should we add this ?

@nabobalis
Copy link
Contributor

it only mentions the example gallery . If you have any ideas then i can add the links over there as well. @nabobalis , any update ?

What do you think we should update?

@nabobalis , the main readme has links for chat and mailing list , but lacks the link for community forum . Should we add this ?

Yes.

@ryuusama09
Copy link
Contributor Author

it only mentions the example gallery . If you have any ideas then i can add the links over there as well. @nabobalis , any update ?

What do you think we should update?
I dont think the example gallery really needs such kind of update. The reason being the main readme as well as the documentation for newcomers handles this already :)

@nabobalis , the main readme has links for chat and mailing list , but lacks the link for community forum . Should we add this ?

Yes.

@ryuusama09
Copy link
Contributor Author

it only mentions the example gallery . If you have any ideas then i can add the links over there as well. @nabobalis , any update ?

What do you think we should update?

@nabobalis , the main readme has links for chat and mailing list , but lacks the link for community forum . Should we add this ?

Yes.

in this case I can update the main readme and it shall end this issue

@nabobalis
Copy link
Contributor

it only mentions the example gallery . If you have any ideas then i can add the links over there as well. @nabobalis , any update ?

What do you think we should update?

@nabobalis , the main readme has links for chat and mailing list , but lacks the link for community forum . Should we add this ?

Yes.

in this case I can update the main readme and it shall end this issue

Sure.

@nabobalis nabobalis merged commit c2214ea into sunpy:main Jan 20, 2023
@nabobalis
Copy link
Contributor

Thanks again @ryuusama09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants