Fix HISTORY key in test maps created from header files
#6728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So far the tests are ok. |
nabobalis
approved these changes
Jan 25, 2023
nabobalis
added
the
Merge When CI Passes
|
The figure test failure is unrelated |
|
Online fails are the same in my eyes. |
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Jan 25, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug in the dummy test map creation where, because the maps were created directly from astropy header objects, the HISTORY (and COMMENTS) keys were not being formatted as a single string.
This was discovered in #6725 when checking the HISTORY field for a specific key.
This should have no impact on any of the existing tests.