-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fig-devdeps : Have to add a unit to lon.coord_wrap #6731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
added
visualization
Affects the visualization submodule
No Changelog Entry Needed
CodeFix
labels
Jan 26, 2023
nabobalis
commented
Jan 26, 2023
nabobalis
changed the title
Have to add a unit to lon.coord_wrap
fig-devdesp : Have to add a unit to lon.coord_wrap
Jan 26, 2023
nabobalis
changed the title
fig-devdesp : Have to add a unit to lon.coord_wrap
fig-devdeps : Have to add a unit to lon.coord_wrap
Jan 26, 2023
dstansby
requested changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, would be good to parse the version properley!
Should be ok now. |
dstansby
approved these changes
Jan 31, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Jan 31, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream astropy issue was merged astropy/astropy#14050
This should fail again in future as we have 2 examples that make a similar call but we will need to wait for the release of astropy 5.3.