Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fig-devdeps : Have to add a unit to lon.coord_wrap #6731

Merged
merged 1 commit into from
Jan 31, 2023
Merged

fig-devdeps : Have to add a unit to lon.coord_wrap #6731

merged 1 commit into from
Jan 31, 2023

Conversation

nabobalis
Copy link
Contributor

@nabobalis nabobalis commented Jan 26, 2023

Upstream astropy issue was merged astropy/astropy#14050

This should fail again in future as we have 2 examples that make a similar call but we will need to wait for the release of astropy 5.3.

@nabobalis nabobalis added visualization Affects the visualization submodule No Changelog Entry Needed CodeFix labels Jan 26, 2023
@nabobalis nabobalis changed the title Have to add a unit to lon.coord_wrap fig-devdesp : Have to add a unit to lon.coord_wrap Jan 26, 2023
@nabobalis nabobalis marked this pull request as ready for review January 26, 2023 01:19
@nabobalis nabobalis requested a review from a team as a code owner January 26, 2023 01:19
@nabobalis nabobalis changed the title fig-devdesp : Have to add a unit to lon.coord_wrap fig-devdeps : Have to add a unit to lon.coord_wrap Jan 26, 2023
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, would be good to parse the version properley!

@nabobalis
Copy link
Contributor Author

Yeah, would be good to parse the version properley!

Should be ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Entry Needed visualization Affects the visualization submodule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants