Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak lon_lat example to have correct lon and lat lines #6832

Merged
merged 2 commits into from
Mar 12, 2023
Merged

Tweak lon_lat example to have correct lon and lat lines #6832

merged 2 commits into from
Mar 12, 2023

Conversation

nabobalis
Copy link
Contributor

Someone pointed out we had the wrong lon,lat lines.

I also updated some text and renamed the file.

@nabobalis nabobalis marked this pull request as ready for review March 9, 2023 20:04
@nabobalis nabobalis requested a review from a team as a code owner March 9, 2023 20:04
Copy link
Member

@ayshih ayshih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of tweaks.

Also, I'm not inclined to rename the filename because that makes it much more cumbersome to see the same example at different versions of sunpy (e.g., by selecting different versions in our online docs).

examples/plotting/lon_lat_lines.py Outdated Show resolved Hide resolved
examples/plotting/lon_lat_lines.py Outdated Show resolved Hide resolved
examples/plotting/lon_lat_lines.py Outdated Show resolved Hide resolved
examples/plotting/lon_lat_lines.py Outdated Show resolved Hide resolved
examples/plotting/lon_lat_lines.py Outdated Show resolved Hide resolved
examples/plotting/lon_lat_lines.py Outdated Show resolved Hide resolved
examples/plotting/lon_lat_lines.py Outdated Show resolved Hide resolved
examples/plotting/lon_lat_lines.py Outdated Show resolved Hide resolved
examples/plotting/lon_lat_lines.py Outdated Show resolved Hide resolved
examples/plotting/lon_lat_lines.py Outdated Show resolved Hide resolved
@nabobalis
Copy link
Contributor Author

Also, I'm not inclined to rename the filename because that makes it much more cumbersome to see the same example at different versions of sunpy (e.g., by selecting different versions in our online docs).

Oh that is a good point. I will undo the name change.

Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
@ayshih ayshih merged commit 296cfc7 into sunpy:main Mar 12, 2023
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Mar 12, 2023
meeseeksmachine pushed a commit to meeseeksmachine/sunpy that referenced this pull request Mar 12, 2023
@nabobalis nabobalis deleted the example branch March 12, 2023 02:30
nabobalis added a commit that referenced this pull request Mar 12, 2023
…t lon and lat lines) (#6839)

Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
nabobalis added a commit that referenced this pull request Mar 12, 2023
…t lon and lat lines) (#6838)

Co-authored-by: Nabil Freij <nabil.freij@gmail.com>
Telomelonia pushed a commit to Telomelonia/sunpy that referenced this pull request Mar 17, 2023
* Tweak lon_lat example to have correct lon and lat lines

* Albert fixes my mistakes

Co-authored-by: Albert Y. Shih <ayshih@gmail.com>

---------

Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Change PR only needs one approval to merge No Changelog Entry Needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants