New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the gallery example for mplcairo
plotting
#6835
Conversation
The PR is a good start, but you need to add mplcairo as a dependency for building the docs. We need to verify that the example will actually render for our online docs. Until that is verified, there's no point in polishing the example itself. |
I've been trying to see if this works, but so far I've been having issues getting mplcairo working on Windows as well as Ubuntu. |
We do not want two open PRs fixing the same issue. If @Telomelonia and @Satan-Claws can talk to each other and work on this example, that would be better. |
@Satan-Claws |
Check here and this , it worked for me from the installation method mentioned |
@Telomelonia no no don't close this PR, keep trying and I'll do the same, hopefully one of us gets it soon. |
Yeah makes sense |
Built docs to check if @Telomelonia plotting built the gallery correctly, and this is the output I got. There are no errors but one plot is missing. I can send the html file if anyone needs. |
Thanks, @Satan-Claws, silly me ... I ignored the fact that axes and plots should be in one code block. |
@Telomelonia In case it wasn't apparent, I've been adding commits to your branch to try to get mplcairo to properly render the example |
Thanks @ayshih ... I was struggling to work it out. |
Please don't change the order of the calls at the start of the example. It is formally required that the |
Okay, the example is working now and all spruced up. @Telomelonia should add a changelog entry. We can wait until |
I'd still prefer to hold off on merging this PR until the next version of |
Works for me. Do we have an ETA on a new release? |
The release came yesterday. We can now remove the git requirement and bump the min version to 0.13. |
This reverts commit c04921b.
I rebased and tweaked the gallery version and removed the git requirement. |
NOTE TO MAINAINTERS: SQUASH MERGE |
PR Description
This example will go through how to blend two plots from SunPy using
mplcairo
.Fixes #6517
TODO
Issue