Provide millionths of solar hemisphere unit #6842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 62800c6.
nabobalis
added
No Backport
dstansby
requested changes
Mar 14, 2023
There was a problem hiding this comment.
To start with, please could you update this so the pre-commit check passes? There's instructions on how to do this here: https://docs.sunpy.org/en/latest/dev_guide/contents/code_standards.html#formatting
|
See #1851 (comment) for how this PR needs to be modified |
Telomelonia
force-pushed
the
unit_register
branch
from
a9dcfe7
to
91c7fcd
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
Hi @Telomelonia, I am going to close this pull request. If you have time to come back to this, please reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds the millionths of solar hemisphere units in the
mapfolderFixes #1851
TODOS