Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds query to sort the event type by magnitude #6854

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Adds query to sort the event type by magnitude #6854

merged 2 commits into from
Mar 24, 2023

Conversation

Telomelonia
Copy link
Contributor

@Telomelonia Telomelonia commented Mar 17, 2023 •
edited by nabobalis

PR Description

Adds the query in the examples/acquiring_data/querying_the_GOES_event_list.py to sort the hek_result by magnitude. The default was sorted by time.

Fixes #1005

TODO

  • changelog

@Telomelonia Telomelonia requested a review from a team as a code owner March 17, 2023 09:29
@Telomelonia
Copy link
Contributor Author

pre-commit.ci autofix

@nabobalis nabobalis added No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) No Changelog Entry Needed backport 4.0 Examples Affects the Example Gallery Minor Change PR only needs one approval to merge and removed No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) labels Mar 17, 2023
nabobalis
nabobalis reviewed Mar 17, 2023
View reviewed changes
changelog/6854.doc.rst Outdated Show resolved Hide resolved
@Telomelonia
Copy link
Contributor Author

pre-commit.ci autofix

1 similar comment
@Telomelonia
Copy link
Contributor Author

pre-commit.ci autofix

@Telomelonia
Copy link
Contributor Author

@nabobalis
I think it's done and ready for merge

@nabobalis nabobalis added Merge When CI Passes Hit that merge button when it's all green! and removed backport 4.0 labels Mar 24, 2023
@nabobalis nabobalis merged commit c4a5277 into sunpy:main Mar 24, 2023
@nabobalis
Copy link
Contributor

Thanks for the PR @Telomelonia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
Examples Affects the Example Gallery Merge When CI Passes Hit that merge button when it's all green! Minor Change PR only needs one approval to merge No Changelog Entry Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an example on how to sort the results from HEK
2 participants
@Telomelonia @nabobalis