Adds suggestion in the example autoalign/reproject to use assume_spherical_screen()
#6855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
nabobalis
added
backport 4.0
Minor Change
ayshih
approved these changes
Mar 22, 2023
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
Co-authored-by: Albert Y. Shih <ayshih@gmail.com>
nabobalis
approved these changes
Mar 22, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Mar 22, 2023
…oject to use `assume_spherical_screen()`
|
Thanks for the PR @davnish |
meeseeksmachine
pushed a commit
to meeseeksmachine/sunpy
that referenced
this pull request
Mar 22, 2023
…oject to use `assume_spherical_screen()`
nabobalis
pushed a commit
that referenced
this pull request
Mar 22, 2023
…lign/reproject to use `assume_spherical_screen()`) (#6878) Co-authored-by: Nischal Singh <32027279+davnish@users.noreply.github.com>
nabobalis
pushed a commit
that referenced
this pull request
Mar 22, 2023
…lign/reproject to use `assume_spherical_screen()`) (#6877) Co-authored-by: Nischal Singh <32027279+davnish@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a suggestion in these two examples:
This suggestion tells the user that Off-disks HMI data is not retained here, and to retain the data they can use
Helioprojective.assume_spherical_screen()to retain the data.Merging this PR:
Closes #5988