Formally deprecate sunpy.database #6869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
added
the
No Backport
dstansby
force-pushed
the
deprecated-database
branch
from
8d7f7d2
to
f53a55c
Compare
Cadair
approved these changes
Mar 22, 2023
dstansby
force-pushed
the
deprecated-database
branch
from
f53a55c
to
e947183
Compare
Cadair
approved these changes
Mar 22, 2023
alasdairwilson
approved these changes
Mar 22, 2023
nabobalis
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there hasn't been a big uproar about the pending deprecation we put in 4.1, this properley deprecates `sunpy.database. I've removed the guide, but left the API reference (with a new warning).