New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring the "Units" section of the guide #6879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtbarnes
force-pushed
the
units-docs-refactoring
branch
from
March 22, 2023 19:03
1921b76
to
8bf962e
Compare
nabobalis
added
Documentation
Affects the documentation
No Changelog Entry Needed
labels
Mar 24, 2023
wtbarnes
force-pushed
the
units-docs-refactoring
branch
from
March 25, 2023 21:29
8bf962e
to
5994034
Compare
Cadair
reviewed
Mar 29, 2023
dstansby
reviewed
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍 - I've left a few suggestions and changes
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
wtbarnes
force-pushed
the
units-docs-refactoring
branch
from
April 10, 2023 18:31
7c1c573
to
1e14754
Compare
dstansby
approved these changes
Apr 15, 2023
Co-authored-by: David Stansby <dstansby@gmail.com>
nabobalis
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6862
I've borrowed a lot of inspiration from the MetPy docs on units: https://unidata.github.io/MetPy/latest/tutorials/unit_tutorial.html