Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the "Units" section of the guide #6879

Merged
merged 17 commits into from Apr 16, 2023

Conversation

wtbarnes
Copy link
Member

Fixes #6862

I've borrowed a lot of inspiration from the MetPy docs on units: https://unidata.github.io/MetPy/latest/tutorials/unit_tutorial.html

@wtbarnes wtbarnes marked this pull request as ready for review March 25, 2023 21:29
docs/tutorial/units.rst Outdated Show resolved Hide resolved
Copy link
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍 - I've left a few suggestions and changes

docs/tutorial/units.rst Outdated Show resolved Hide resolved
docs/tutorial/units.rst Outdated Show resolved Hide resolved
docs/tutorial/units.rst Outdated Show resolved Hide resolved
docs/tutorial/units.rst Outdated Show resolved Hide resolved
docs/tutorial/units.rst Outdated Show resolved Hide resolved
docs/tutorial/units.rst Outdated Show resolved Hide resolved
docs/tutorial/units.rst Show resolved Hide resolved
docs/tutorial/units.rst Outdated Show resolved Hide resolved
docs/tutorial/units.rst Outdated Show resolved Hide resolved
docs/tutorial/units.rst Outdated Show resolved Hide resolved
wtbarnes and others added 16 commits April 10, 2023 14:30
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
Co-authored-by: David Stansby <dstansby@gmail.com>
@dstansby dstansby added this to the 5.0.0 milestone Apr 14, 2023
Co-authored-by: David Stansby <dstansby@gmail.com>
@nabobalis nabobalis merged commit 54c2458 into sunpy:main Apr 16, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review "Units" section of the tutorial
4 participants